Skip to content

Extra IPsec cleanup

Leon Romanovsky netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 11 repliesIn review

Changes in v1 from the cover letter

* changed target from mlx5-next to net-next.
* Improved commit message in patch #1
* Left function names intact, with _accel_ word in it.
v0: https://lore.kernel.org/all/[email protected]

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17net/mlx5: Simplify IPsec flow steering init/cleanup functionsdrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.h+27 -540 replies
2/17net/mlx5: Check IPsec TX flow steering namespace in advancedrivers/net/ethernet/mellanox/mlx5/core/en/fs.h drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h +1 more+11 -80 replies
3/17net/mlx5: Don't hide fallback to software IPsec in FS codedrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c+17 -300 replies
4/17net/mlx5: Reduce useless indirection in IPsec FS add/delete flowsdrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c+9 -200 replies
5/17net/mlx5: Store IPsec ESN update work in XFRM statedrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_offload.c +1 more+33 -720 replies
6/17net/mlx5: Remove useless validity checkdrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_offload.c include/linux/mlx5/accel.h+0 -540 replies
7/17net/mlx5: Merge various control path IPsec headers into one filedrivers/net/ethernet/mellanox/mlx5/core/en/params.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h +9 more+117 -1840 replies
8/17net/mlx5: Remove indirections from esp functionsdrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_offload.c+12 -350 replies
9/17net/mlx5: Simplify HW context interfaces by using SA entrydrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_offload.c+62 -1972 replies
10/17net/mlx5: Clean IPsec FS add/delete rulesdrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c+34 -382 replies
11/17net/mlx5: Make sure that no dangling IPsec FS pointers existdrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c+73 -1560 replies
12/17net/mlx5: Don't advertise IPsec netdev support for non-IPsec devicedrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c+3 -00 replies
13/17net/mlx5: Simplify IPsec capabilities logicdrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_offload.c+16 -312 replies
14/17net/mlx5: Remove not-supported ICV lengthdrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_offload.c include/linux/mlx5/mlx5_ifc.h+1 -180 replies
15/17net/mlx5: Cleanup XFRM attributes structdrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c +1 more+8 -312 replies
16/17net/mlx5: Allow future addition of IPsec object modifiersdrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_offload.c+3 -01 reply
17/17net/mlx5: Don't perform lookup after already known sec_pathdrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c+0 -10 replies

Reviews trailers per patch

All 17 patches have a Reviewed-by or Acked-by.

PatchRaed SalemSaeed Mahameed
1/17R-b
2/17R-b R-b
3/17R-b
4/17R-b
5/17R-b
6/17R-b
7/17R-b
8/17R-b
9/17R-b
10/17R-b
11/17R-b
12/17R-b
13/17R-b
14/17R-b
15/17R-b
16/17R-b
17/17R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next v1 00/17] Extra IPsec cleanup

From: Leon Romanovsky <[email protected]>

Changelog:
v1:
* changed target from mlx5-next to net-next.
* Improved commit message in patch #1
* Left function names intact, with _accel_ word in it.
v0: https://lore.kernel.org/all/[email protected]

--------------------
After FPGA IPsec removal, we can go further and make sure that flow steering logic is aligned to mlx5_core standard together with deep cleaning of whole IPsec path.

Thanks

Leon Romanovsky (17):
net/mlx5: Simplify IPsec flow steering init/cleanup functions net/mlx5: Check IPsec TX flow steering namespace in advance net/mlx5: Don't hide fallback to software IPsec in FS code net/mlx5: Reduce useless indirection in IPsec FS add/delete flows net/mlx5: Store IPsec ESN update work in XFRM state net/mlx5: Remove useless validity check
net/mlx5: Merge various control path IPsec headers into one file net/mlx5: Remove indirections from esp functions net/mlx5: Simplify HW context interfaces by using SA entry net/mlx5: Clean IPsec FS add/delete rules
net/mlx5: Make sure that no dangling IPsec FS pointers exist net/mlx5: Don't advertise IPsec netdev support for non-IPsec device net/mlx5: Simplify IPsec capabilities logic
net/mlx5: Remove not-supported ICV length
net/mlx5: Cleanup XFRM attributes struct
net/mlx5: Allow future addition of IPsec object modifiers net/mlx5: Don't perform lookup after already known sec_path

 .../net/ethernet/mellanox/mlx5/core/en/fs.h   |   1 -
 .../ethernet/mellanox/mlx5/core/en/params.c   |   2 +-
 .../mellanox/mlx5/core/en_accel/ipsec.c       | 174 +++------
 .../mellanox/mlx5/core/en_accel/ipsec.h       |  85 +++-
 .../mellanox/mlx5/core/en_accel/ipsec_fs.c    | 362 ++++++------------
 .../mellanox/mlx5/core/en_accel/ipsec_fs.h    |   4 +-
 .../mlx5/core/en_accel/ipsec_offload.c        | 331 +++-------------
 .../mlx5/core/en_accel/ipsec_offload.h        |  14 -
 .../mellanox/mlx5/core/en_accel/ipsec_rxtx.c  |   6 +-
 .../mellanox/mlx5/core/en_accel/ipsec_stats.c |   4 +-
 .../net/ethernet/mellanox/mlx5/core/en_main.c |   1 -
 .../net/ethernet/mellanox/mlx5/core/en_rx.c   |   2 +-
 .../net/ethernet/mellanox/mlx5/core/main.c    |   2 +-
 include/linux/mlx5/accel.h                    | 153 --------
 include/linux/mlx5/mlx5_ifc.h                 |   2 -
 15 files changed, 320 insertions(+), 823 deletions(-)
 delete mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_offload.h
 delete mode 100644 include/linux/mlx5/accel.h
Signature · 1 line
2.35.1