Skip to content

9pfs: macOS host fixes

Christian Schoenebeck qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 17 repliesIn review
  2. v46 patches 5 repliesSuperseded
  3. v35 of 6 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches21 repliesSuperseded
v15 patches21 repliesSuperseded

Changes in v5 from the cover letter

* Check return value of snprintf() instead of strlen(filename).

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/69pfs: fix qemu_mknodat(S_IFREG) on macOShw/9pfs/9p-util-darwin.c+9 -00 replies
2/69pfs: fix qemu_mknodat(S_IFSOCK) on macOShw/9pfs/9p-util-darwin.c+41 -16 replies
3/69pfs: fix wrong encoding of rdev field in Rgetattr on macOShw/9pfs/9p-util.h hw/9pfs/9p.c+40 -10 replies
4/69pfs: fix wrong errno being sent to Linux client on macOS hosthw/9pfs/9p-util.h hw/9pfs/9p.c+32 -010 replies
5/69pfs: fix removing non-existent POSIX ACL xattr on macOS hosthw/9pfs/9p-posix-acl.c+10 -20 replies
6/69pfs: fix qemu_mknodat() to always return -1 on error on macOS hosthw/9pfs/9p-util-darwin.c+2 -10 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchGreg KurzWill CohenAkihiko Odaki
1/6R-b R-b
2/6R-b R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/6] 9pfs: macOS host fixes

A bunch of fixes for recently (in QEMU 7.0) added 9p support on macOS hosts.

Note: there are still issues to address with case-insensitive file systems on macOS hosts. I sent a separate RFC on that icase issue:
https://lore.kernel.org/qemu-devel/1757498.AyhHxzoH2B@silver/

v4 -> v5:

* Check return value of snprintf() instead of strlen(filename).

    [patch 2]

Christian Schoenebeck (6):
9pfs: fix qemu_mknodat(S_IFREG) on macOS
9pfs: fix qemu_mknodat(S_IFSOCK) on macOS
9pfs: fix wrong encoding of rdev field in Rgetattr on macOS 9pfs: fix wrong errno being sent to Linux client on macOS host 9pfs: fix removing non-existent POSIX ACL xattr on macOS host 9pfs: fix qemu_mknodat() to always return -1 on error on macOS host

 hw/9pfs/9p-posix-acl.c   | 12 +++++--
 hw/9pfs/9p-util-darwin.c | 54 +++++++++++++++++++++++++++++--
 hw/9pfs/9p-util.h        | 69 ++++++++++++++++++++++++++++++++++++++++
 hw/9pfs/9p.c             |  4 ++-
 4 files changed, 134 insertions(+), 5 deletions(-)
Signature · 1 line
2.32.0 (Apple Git-132)