Skip to content

Allow use of JSON in domain configuration files

Elliott Mitchell xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesIn review
  2. v12 patches 5 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tools/xl: Sort create command optionstools/xl/xl_cmdtable.c tools/xl/xl_vmcontrol.c+26 -261 reply
2/3tools/xl: Use sparse init for dom_info, remove duplicate varstools/xl/xl.h tools/xl/xl_vmcontrol.c+37 -401 reply
3/3tools/xl: Allow specifying JSON for domain configuration file formattools/xl/xl.h tools/xl/xl_cmdtable.c tools/xl/xl_vmcontrol.c+17 -23 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchAnthony PERARD
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Allow use of JSON in domain configuration files

While the traditional domain configuration file format works acceptably, I can see uses for having full JSON support. As such add "-j" and "-J" to xl create to specify format. The traditional format is the current default.

While attempting this, it came up that options for xl create aren't in a consistent order. I'm concerned about moving the VNC options apart, but the others have been sorted.

Due to one issue in the previous round I ended up examing the dom_info variable in main_create(). The situation there is a bit tangled. There were shadow variables for everything in dom_info. Unfortunately the short-hand serves to confuse, so I believe the appropriate action is to remove the shadows. Appears .dry_run had effectively been deprecated, but not fully removed; as such now fully remove it.

Rename everything "format" to "config_format".

Elliott Mitchell (3):
tools/xl: Sort create command options
tools/xl: Use sparse init for dom_info, remove duplicate vars tools/xl: Allow specifying JSON for domain configuration file format

 tools/xl/xl.h           |   6 ++-
 tools/xl/xl_cmdtable.c  |  14 ++---
 tools/xl/xl_vmcontrol.c | 114 +++++++++++++++++++++-------------------
 3 files changed, 73 insertions(+), 61 deletions(-)
Signature · 1 line
2.30.2