Skip to content

memblock tests: update style of comments

Rebecca Mckeever linux-mm lkml outreachy 4 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 2 repliesApplied
  2. v35 patches 3 repliesSuperseded
  3. v24 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches5 repliesSuperseded

Changes in v4 from the cover letter

PATCH 1 and PATCH 2: add Reviewed-by tags
PATCH 1 through PATCH 4:
Correct grammar
Replace references to first or second (block/region) with r1 or r2 Add references to r1 or r2 as needed for clarity
---

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/5memblock tests: update style of comments for memblock_add_*() functionstools/testing/memblock/tests/basic_api.c+59 -260 replies
2/5memblock tests: update style of comments for memblock_reserve_*() functionstools/testing/memblock/tests/basic_api.c+63 -310 replies
3/5memblock tests: update style of comments for memblock_remove_*() functionstools/testing/memblock/tests/basic_api.c+81 -300 replies
4/5memblock tests: update style of comments for memblock_free_*() functionstools/testing/memblock/tests/basic_api.c+75 -270 replies
5/5memblock tests: remove completed TODO itemtools/testing/memblock/TODO+0 -30 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid Hildenbrand
SeriesR-b
1/5R-b
2/5R-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] memblock tests: update style of comments

These patches update the style of comments for memblock_add_*(), memblock_reserve_*(), memblock_remove_*(), and memblock_free_*() functions to match the style of comments in tests/alloc_*.c and remove extra spaces in those comments to conform to Linux kernel coding style. This completes an item from the TODO list.

Rebecca Mckeever (5):
memblock tests: update style of comments for memblock_add_*()
functions
memblock tests: update style of comments for memblock_reserve_*()
functions
memblock tests: update style of comments for memblock_remove_*()
functions
memblock tests: update style of comments for memblock_free_*()
functions
memblock tests: remove completed TODO item

 tools/testing/memblock/TODO              |   3 -
 tools/testing/memblock/tests/basic_api.c | 392 ++++++++++++++++-------
 2 files changed, 278 insertions(+), 117 deletions(-)

---
Changes

v1 -> v2
PATCH 1:
Add a comma
Move separator outside block name
Squash white space edit into PATCH 2
PATCH 1 and PATCH 2: add a colon before memory block visuals Add PATCH 3: update style of comments for memblock_remove_*() functions Add PATCH 4: update style of comments for memblock_free_*() functions

v2 -> v3
Add PATCH 5: remove completed TODO item
Add changes summary

v3 -> v4
PATCH 1 and PATCH 2: add Reviewed-by tags
PATCH 1 through PATCH 4:
Correct grammar
Replace references to first or second (block/region) with r1 or r2 Add references to r1 or r2 as needed for clarity
---

Signature · 1 line
2.32.0