Skip to content

RFC: Remove deprecated audio features

Martin Kletzander qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 25 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18hw/audio: Remove -soundhw supportdocs/about/deprecated.rst docs/about/removed-features.rst docs/qdev-device-use.txt +16 more+19 -2993 replies
2/18hw/input/tsc210x: Extract common init code into new functionhw/input/tsc210x.c+24 -441 reply
3/18hw/audio: Simplify hda audio inithw/audio/hda-codec.c hw/audio/intel-hda.c hw/audio/intel-hda.h+20 -182 replies
4/18hw/audio/lm4549: Add errp error reporting to init functionhw/audio/lm4549.c hw/audio/lm4549.h hw/audio/pl041.c+5 -31 reply
5/18tests/qtest: Specify audiodev= and -audiodevtests/qtest/ac97-test.c tests/qtest/es1370-test.c tests/qtest/fuzz/generic_fuzz_configs.h +1 more+18 -92 replies
6/18ui/vnc: Require audiodev=ui/vnc.c+9 -63 replies
7/18Introduce machine's default-audiodev propertyhw/core/machine.c include/hw/boards.h+24 -02 replies
8/18audio: Add easy dummy audio initialiseraudio/audio.c audio/audio.h+36 -00 replies
9/18hw/display/xlnx_dp.c: Add audiodev propertyhw/display/xlnx_dp.c+6 -00 replies
10/18hw/input/tsc210x.c: Support machine-default audiodev with fallbackhw/input/tsc210x.c+8 -00 replies
11/18hw/arm: Support machine-default audiodev with fallbackhw/arm/integratorcp.c hw/arm/musicpal.c hw/arm/omap2.c +6 more+53 -60 replies
12/18hw/ppc: Support machine-default audiodev with fallbackhw/ppc/prep.c+4 -00 replies
13/18audio: Make AUD_register_card fallible and require audiodev=audio/audio.c audio/audio.h hw/arm/omap2.c +13 more+57 -212 replies
14/18audio: Require AudioState in AUD_add_captureaudio/audio.c+2 -41 reply
15/18audio: Be more strict during audio backend initialisationaudio/audio.c docs/about/deprecated.rst docs/about/removed-features.rst+34 -1281 reply
16/18audio: Remove legacy audio environment variables and optionsaudio/audio.c audio/audio.h audio/audio_legacy.c +5 more+9 -5911 reply
17/18audio: Remove unused can_be_defaultaudio/alsaaudio.c audio/audio_int.h audio/coreaudio.m +8 more+0 -111 reply
18/18audio/spiceaudio: Fail initialisation when not using spiceaudio/spiceaudio.c+2 -11 reply

Reviews trailers per patch

7 of 18 patches have a Reviewed-by or Acked-by.

PatchDaniel P. BerrangéStefan Hajnoczi
1/18R-b
2/18R-b
3/18R-b
4/18R-b
5/18R-b
6/18
7/18
8/18
9/18
10/18
11/18
12/18
13/18
14/18
15/18
16/18R-b
17/18R-b
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/18] RFC: Remove deprecated audio features

I wanted to deal with https://bugzilla.redhat.com/2043498 and I got a suggesstion that removing deprecated features could actually make it easier to propagate the error. In the end (last patch) it turns out the error is still just reported with error_fatal, so it probably is not really needed, but I really wanted to dig into QEMU more and learn some of the internals for quite some time now. So I used the opportunity. The one-liner ended up being an 18 patch series which was, for someone who has just one commit in QEMU codebase, a pretty challenging task. Although I tried my best to do things properly, I am not sure whether I handled everything correctly, hence the RFC.

Any comments are very much appreciated. Thanks and have a nice day ;)

Martin Kletzander (18):
hw/audio: Remove -soundhw support
hw/input/tsc210x: Extract common init code into new function hw/audio: Simplify hda audio init
hw/audio/lm4549: Add errp error reporting to init function tests/qtest: Specify audiodev= and -audiodev
ui/vnc: Require audiodev=
Introduce machine's default-audiodev property
audio: Add easy dummy audio initialiser hw/display/xlnx_dp.c: Add audiodev property hw/input/tsc210x.c: Support machine-default audiodev with fallback hw/arm: Support machine-default audiodev with fallback hw/ppc: Support machine-default audiodev with fallback
audio: Make AUD_register_card fallible and require audiodev=
audio: Require AudioState in AUD_add_capture
audio: Be more strict during audio backend initialisation
audio: Remove legacy audio environment variables and options
audio: Remove unused can_be_default
audio/spiceaudio: Fail initialisation when not using spice

 audio/alsaaudio.c                             |   1 -
 audio/audio.c                                 | 204 +++----
 audio/audio.h                                 |   5 +-
 audio/audio_int.h                             |   1 -
 audio/audio_legacy.c                          | 555 ------------------
 audio/coreaudio.m                             |   1 -
 audio/dbusaudio.c                             |   1 -
 audio/dsoundaudio.c                           |   1 -
 audio/jackaudio.c                             |   1 -
 audio/meson.build                             |   1 -
 audio/noaudio.c                               |   1 -
 audio/ossaudio.c                              |   1 -
 audio/paaudio.c                               |   1 -
 audio/sdlaudio.c                              |   1 -
 audio/spiceaudio.c                            |   3 +-
 audio/wavaudio.c                              |   1 -
 docs/about/deprecated.rst                     |  24 -
 docs/about/removed-features.rst               |  27 +
 docs/qdev-device-use.txt                      |  21 +-
 docs/replay.txt                               |   2 +-
 hw/arm/integratorcp.c                         |   8 +-
 hw/arm/musicpal.c                             |   8 +-
 hw/arm/omap2.c                                |  11 +-
 hw/arm/realview.c                             |   3 +
 hw/arm/spitz.c                                |  10 +-
 hw/arm/versatilepb.c                          |   3 +
 hw/arm/vexpress.c                             |   3 +
 hw/arm/xlnx-zcu102.c                          |   4 +
 hw/arm/z2.c                                   |  12 +-
 hw/audio/ac97.c                               |   9 +-
 hw/audio/adlib.c                              |   9 +-
 hw/audio/cs4231a.c                            |   8 +-
 hw/audio/es1370.c                             |   8 +-
 hw/audio/gus.c                                |   6 +-
 hw/audio/hda-codec.c                          |  37 +-
 hw/audio/intel-hda.c                          |  25 +-
 hw/audio/intel-hda.h                          |   2 +-
 hw/audio/lm4549.c                             |   7 +-
 hw/audio/lm4549.h                             |   3 +-
 hw/audio/meson.build                          |   1 -
 hw/audio/pcspk.c                              |  15 +-
 hw/audio/pl041.c                              |   2 +-
 hw/audio/sb16.c                               |   9 +-
 hw/audio/soundhw.c                            | 177 ------
 hw/audio/wm8750.c                             |   5 +-
 hw/core/machine.c                             |  23 +
 hw/display/xlnx_dp.c                          |  12 +-
 hw/input/tsc210x.c                            |  79 ++-
 hw/ppc/prep.c                                 |   4 +
 hw/usb/dev-audio.c                            |   5 +-
 include/hw/audio/soundhw.h                    |  15 -
 include/hw/boards.h                           |   1 +
 qemu-options.hx                               |  37 --
 .../codeconverter/test_regexps.py             |   1 -
 softmmu/qdev-monitor.c                        |   2 -
 softmmu/vl.c                                  |  10 -
 tests/qtest/ac97-test.c                       |   3 +-
 tests/qtest/es1370-test.c                     |   3 +-
 tests/qtest/fuzz/generic_fuzz_configs.h       |   6 +-
 tests/qtest/intel-hda-test.c                  |  15 +-
 ui/vnc.c                                      |  15 +-
 61 files changed, 329 insertions(+), 1140 deletions(-)
 delete mode 100644 audio/audio_legacy.c
 delete mode 100644 hw/audio/soundhw.c
 delete mode 100644 include/hw/audio/soundhw.h
Signature · 1 line
2.35.1