Be explicit with XFRM offload direction
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | xfrm: free not used XFRM_ESP_NO_TRAILER flaginclude/ net/ net/ | +1 | 1 reply | |
| 2/8 | xfrm: delete not used number of external headersinclude/ net/ | +0 | 1 reply | |
| 3/8 | xfrm: rename xfrm_state_offload struct to allow reuseinclude/ net/ net/ +1 more | +9 | 1 reply | |
| 4/8 | xfrm: store and rely on direction to construct offload flagsinclude/ net/ net/ | +15 | 0 replies | |
| 5/8 | ixgbe: propagate XFRM offload state direction instead of flagsdrivers/ drivers/ drivers/ +1 more | +9 | 0 replies | |
| 6/8 | netdevsim: rely on XFRM state direction instead of flagsdrivers/ | +1 | 1 reply | |
| 7/8 | net/mlx5e: Use XFRM state direction instead of flagsdrivers/ | +5 | 0 replies | |
| 8/8 | xfrm: drop not needed flags variable in XFRM offload structinclude/ net/ | +0 | 0 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Raed Salem | David S. Miller | Jakub Kicinski |
|---|---|---|---|
| 1/8 | R-b | A-b | |
| 2/8 | R-b | A-b | |
| 3/8 | R-b | A-b | |
| 4/8 | R-b | ||
| 5/8 | R-b | ||
| 6/8 | R-b | A-b | |
| 7/8 | R-b | ||
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH ipsec-next 0/8] Be explicit with XFRM offload direction
From: Leon Romanovsky <[email protected]>
Hi Steffen,
I may admit that the title of this series is not the best one as it contains straightforward cleanups and code that converts flags to something less confusing.
This series follows removal of FPGA IPsec code from the mlx5 driver and based on net-next commit 4950b6990e3b ("Merge branch 'ocelot-vcap-cleanups'").
As such, first two patches delete code that was used by mlx5 FPGA code but isn't needed anymore.
Third patch is simple struct rename.
Rest of the patches separate user's provided flags variable from driver's usage. This allows us to created more simple in-kernel interface, that supports type checking without blending different properties into one variable. It is achieved by converting flags to specific bitfield variables with clear, meaningful names.
Such change allows us more clear addition of new input flags needed to mark IPsec offload type.
The followup code uses this extensively:
https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=xfrm-next
Thanks
Leon Romanovsky (8):
xfrm: free not used XFRM_ESP_NO_TRAILER flag
xfrm: delete not used number of external headers
xfrm: rename xfrm_state_offload struct to allow reuse
xfrm: store and rely on direction to construct offload flags
ixgbe: propagate XFRM offload state direction instead of flags
netdevsim: rely on XFRM state direction instead of flags net/mlx5e: Use XFRM state direction instead of flags
xfrm: drop not needed flags variable in XFRM offload struct
.../net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 9 ++++----- .../net/ethernet/intel/ixgbe/ixgbe_ipsec.h | 2 +- drivers/net/ethernet/intel/ixgbevf/ipsec.c | 6 +++--- drivers/net/ethernet/intel/ixgbevf/ipsec.h | 2 +- .../mellanox/mlx5/core/en_accel/ipsec.c | 10 +++++----- drivers/net/netdevsim/ipsec.c | 2 +- include/net/xfrm.h | 20 +++++++++++-------- net/ipv4/esp4.c | 6 ------ net/ipv6/esp6.c | 6 ------ net/xfrm/xfrm_device.c | 15 +++++++------- net/xfrm/xfrm_state.c | 4 ++-- net/xfrm/xfrm_user.c | 5 +++-- 12 files changed, 40 insertions(+), 47 deletions(-)
Signature · 1 line
2.35.1