Skip to content

bisect: status improvements when bisect is not fully fleshed out

Chris Down git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 16 repliesSuperseded

Changes in v3 from the cover letter

- Fix test indentation
- Rename bs to state
- Use `unsigned int' for nr_{good,bad}
- Pass the bisect state struct as an argument into bisect_print_status
- Zero-initialise bisect_state directly, don't use memset()
- Fix multiline comment style in bisect.h
- Use strbuf in bisect_log_printf
- Change `git bisect log' use an output file in tests instead of piping

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2bisect: output state before we are ready to compute bisectionbisect.h builtin/bisect--helper.c t/t6030-bisect-porcelain.sh+67 -130 replies
2/2bisect: output bisect setup status in bisect logbuiltin/bisect--helper.c t/t6030-bisect-porcelain.sh+31 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] bisect: status improvements when bisect is not fully fleshed out

When bisecting, we currently don't output anything before bisection starts in earnest, which can result in some confusion. For example, in the case illustrated in the first commit in this patch series, it's trivial to accidentally misspell a tag or branch and accidentally end up in an unintended state with no clear indication about what happened.

This patch series makes it so that we give information about bisect state even before the bisect is ready to begin. We also store these changes in state to the bisect log.

v2:

- Move to improve bisect output overall, instead of just warning for the specific unintended pathspec case.

v3:

- Fix test indentation
- Rename bs to state
- Use `unsigned int' for nr_{good,bad}
- Pass the bisect state struct as an argument into bisect_print_status
- Zero-initialise bisect_state directly, don't use memset()
- Fix multiline comment style in bisect.h
- Use strbuf in bisect_log_printf
- Change `git bisect log' use an output file in tests instead of piping

Chris Down (2):
bisect: output state before we are ready to compute bisection
bisect: output bisect setup status in bisect log

 bisect.h                    |  9 +++++
 builtin/bisect--helper.c    | 69 ++++++++++++++++++++++++++++++-------
 t/t6030-bisect-porcelain.sh | 28 +++++++++++++++
 3 files changed, 93 insertions(+), 13 deletions(-)
Signature · 1 line
2.36.0