BPF redundant scheduler, part 2
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v25 Latest5 patches 5 repliesIn review
- v245 patches 1 replySuperseded
- v235 patches 2 repliesSuperseded
Earlier versions · 23
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v22 | 5 patches | 4 replies | Superseded | |
| v21 | 7 patches | 3 replies | Superseded | |
| v20 | 7 patches | 6 replies | Superseded | |
| v19 posting 2/2 | 6 patches | 0 replies | Superseded | |
| v19 posting 1/2 | 9 patches | 13 replies | Superseded | |
| v18 | 15 patches | 5 replies | Superseded | |
| v17 | 15 patches | 2 replies | Superseded | |
| v16 | 15 patches | 2 replies | Superseded | |
| v15 | 19 patches | 4 replies | Superseded | |
| v14 | 7 patches | 3 replies | Superseded | |
| v13 | 6 patches | 0 replies | Superseded | |
| v12 | 5 patches | 2 replies | Superseded | |
| v11 | 5 patches | 3 replies | Superseded | |
| v10 | 5 patches | 5 replies | Superseded | |
| v9 | 6 patches | 4 replies | Superseded | |
| v8 | 6 patches | 2 replies | Superseded | |
| v7 | 5 patches | 2 replies | Superseded | |
| v6 | 9 patches | 3 replies | Superseded | |
| v5 | 7 patches | 3 replies | Superseded | |
| v4 | 5 patches | 2 replies | Superseded | |
| v3 | 5 patches | 1 reply | Superseded | |
| v2 | 5 patches | 1 reply | Superseded | |
| v1 | 4 patches | 2 replies | Superseded |
Changes in v25 from the cover letter
- update calls to mptcp_subflow_set_scheduled(subflow, false) in __mptcp_subflow_push_pending().
- rebased on "tag: export/20221215T054923"
Patches in v25 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | mptcp: add scheduler wrappersnet/ net/ net/ | +56 | 0 replies | |
| 2/5 | mptcp: use get_send wrappernet/ net/ | +85 | 1 reply | |
| 3/5 | mptcp: use get_retrans wrappernet/ net/ | +44 | 0 replies | |
| 4/5 | selftests/bpf: Add bpf_red schedulertools/ | +45 | 0 replies | |
| 5/5 | selftests/bpf: Add bpf_red testtools/ | +34 | 1 reply |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Mat Martineau |
|---|---|
| Series | R-b |
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH mptcp-next v25 0/5] BPF redundant scheduler, part 2
v25:
- update calls to mptcp_subflow_set_scheduled(subflow, false) in __mptcp_subflow_push_pending().
- rebased on "tag: export/20221215T054923"
v24:
- rename push to keep_pushing
- check the scheduled bit on ssk first
- drop delegate flag
- depends on "mptcp: use msk_owned_by_me helper"
v23:
- patch 2 and 3: clear subflow->scheduled flag on the error paths.
v22:
- update patch 2 as Mat suggested.
- patch 4 and 5 in v21 will send later.
v21:
- address Mat's comments in v20.
- redundant sends on retransmit code path.
v20:
- rebased on "Squash to "mptcp: refactor push_pending logic" v19"
v19:
- patch 1, use 'continue' instead of 'goto again'.
v18:
- some cleanups
- update commit logs.
v17:
- address to Mat's comments in v16
- rebase to export/20221108T055508.
v16:
- keep last_snd and snd_burst in struct mptcp_sock.
- drop "mptcp: register default scheduler".
- drop "mptcp: add scheduler wrappers", move it into "mptcp: use get_send wrapper" and "mptcp: use get_retrans wrapper".
- depends on 'v2, Revert "mptcp: add get_subflow wrappers" - fix divide error in mptcp_subflow_get_send'
v15:
1: "refactor push pending" v10
2-11: "register default scheduler" v3
- move last_snd and snd_burst into struct mptcp_sched_ops
12-19: "BPF redundant scheduler" v15
- split "use get_send wrapper" into two patches
- rebase to export/20221021T061837.
v14:
- add "mptcp: refactor push_pending logic" v10 as patch 1
- drop update_first_pending in patch 4
- drop update_already_sent in patch 5
v13:
- deponds on "refactor push pending" v9.
- Simply 'goto out' after invoking mptcp_subflow_delegate in patch 1.
- All selftests (mptcp_connect.sh, mptcp_join.sh and simult_flows.sh) passed.
v12:
- fix WARN_ON_ONCE(reuse_skb) and WARN_ON_ONCE(!msk->recovery) errors in kernel logs.
v11:
- address to Mat's comments in v10.
- rebase to export/20220908T063452
v10:
- send multiple dfrags in __mptcp_push_pending().
v9:
- drop the extra *err paramenter of mptcp_sched_get_send() as Florian suggested.
v8:
- update __mptcp_push_pending(), send the same data on each subflow.
- update __mptcp_retrans, track the max sent data.
= add a new patch.
v7:
- drop redundant flag in v6
- drop __mptcp_subflows_push_pending in v6
- update redundant subflows support in __mptcp_push_pending
- update redundant subflows support in __mptcp_retrans
v6:
- Add redundant flag for struct mptcp_sched_ops.
- add a dedicated function __mptcp_subflows_push_pending() to deal with redundat subflows push pending.
v5:
- address to Paolo's comment, keep the optimization tomptcp_subflow_get_send() for the non eBPF case.
- merge mptcp_sched_get_send() and __mptcp_sched_get_send() in v4 into one.
- depends on "cleanups for bpf sched selftests".
v4:
- small cleanups in patch 1, 2.
- add TODO in patch 3.
- rebase patch 5 on 'cleanups for bpf sched selftests'.
v3:
- use new API.
- fix the link failure tests issue mentioned in ("https://patchwork.kernel.org/project/mptcp/cover/[email protected]/").
v2:
- add MPTCP_SUBFLOWS_MAX limit to avoid infinite loops when the scheduler always sets call_again to true.
- track the largest copied amount.
- deal with __mptcp_subflow_push_pending() and the retransmit loop.
- depends on "BPF round-robin scheduler" v14.
v1:
Implements the redundant BPF MPTCP scheduler, which sends all packets redundantly on all available subflows.
Geliang Tang (5):
mptcp: add scheduler wrappers
mptcp: use get_send wrapper
mptcp: use get_retrans wrapper
selftests/bpf: Add bpf_red scheduler
selftests/bpf: Add bpf_red test
net/mptcp/protocol.c | 187 +++++++++++------- net/mptcp/protocol.h | 4 + net/mptcp/sched.c | 69 +++++++ .../testing/selftests/bpf/prog_tests/mptcp.c | 34 ++++ .../selftests/bpf/progs/mptcp_bpf_red.c | 45 +++++ 5 files changed, 264 insertions(+), 75 deletions(-) create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_red.c
Signature · 1 line
2.35.3