Skip to content

Implement arm64 specific huge_ptep_get()

Baolin Wang linux-arm-kernel linux-mm lkml 3 versions – Applied

Status from this message: Applied to arm64 (for-next/misc), thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyApplied
  2. v22 patches 4 repliesSuperseded
  3. v12 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- Fix some typos and update the commit message suggested by Anshuman.
- Improve some coding style issues.
- Add reviewed tag from Anshuman.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2arm64/hugetlb: Use ptep_get() to get the pte value of a huge pagearch/arm64/mm/hugetlbpage.c+4 -40 replies
2/2arm64/hugetlb: Implement arm64 specific huge_ptep_get()arch/arm64/include/asm/hugetlb.h arch/arm64/mm/hugetlbpage.c+24 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMuchun SongAnshuman Khandual
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Implement arm64 specific huge_ptep_get()

Hi,

As Mike pointed out [1], the huge_ptep_get() will only return one specific pte value for the CONT-PTE or CONT-PMD size hugetlb on ARM64 system, which will not take into account the subpages' dirty or young bits of a CONT-PTE/PMD size hugetlb page. That will make us miss dirty or young flags of a CONT-PTE/PMD size hugetlb page for those functions that want to check the dirty or young flags of a hugetlb page. For example, the gather_hugetlb_stats() will get inaccurate dirty hugetlb page statistics, and the DAMON for hugetlb monitoring will also get inaccurate access statistics.

To fix this issue, this patch set introduces an ARM64 specific huge_ptep_get() implementation, which will take into account any subpages' dirty or young bits.

[1] https://lore.kernel.org/linux-mm/[email protected]/

Changes from v2:
- Fix some typos and update the commit message suggested by Anshuman.
- Improve some coding style issues.
- Add reviewed tag from Anshuman.

Changes from v1:
- Rebase on next-20220512.
- Update commit message suggested by Muchun.
- Add reviewed tag from Muchun.

Changes from RFC:
- Implement arm64 specific huge_ptep_get() instead of introducing a new interface.
- Add a new patch to convert huge_ptep_get() in hugetlbpage.c

Baolin Wang (2):
arm64/hugetlb: Use ptep_get() to get the pte value of a huge page arm64/hugetlb: Implement arm64 specific huge_ptep_get()

 arch/arm64/include/asm/hugetlb.h |  2 ++
 arch/arm64/mm/hugetlbpage.c      | 30 ++++++++++++++++++++++++++----
 2 files changed, 28 insertions(+), 4 deletions(-)
Signature · 1 line
1.8.3.1