Skip to content

Miscellaneous fixes/improvements

Glenn Washburn grub-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tests: Show host determined fs UUID when hfs UUID test failstests/util/grub-fs-tester.in+1 -13 replies
2/4tests: Add /sbin and /usr/sbin to path in partmap testtests/partmap_test.in+2 -00 replies
3/4formatting: Remove whitespace between N_ macro and open parenthesisgrub-core/commands/macbless.c+2 -40 replies
4/4util/probe.c: Remove unused header includesutil/probe.c+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Miscellaneous fixes/improvements

Patch #1: When the HFS UUID test fails it shows two GRUB generated outputs.
There should be one GRUB output and one host system output, like the other filesystems output. In this case it should show the host generated HFS UUID which is not matching with the GRUB generated one.
Patch #2: If tests are run as non-root user, /sbin and /usr/sbin are usually
not in the path, which will cause the partmap test to fail because it can not find parted (in /usr/sbin on Debian). However, this test does not require root privileges to run successfully, so add those paths to the PATH to allow partmap to successfully run as a non-root user.
Patch #3: I believe the policy is that invocations of the N_ macro should
have no whitespace before the '('. This fixes that in a couple invocations.
Patch #4: The crypto and cryptodisk headers are not needed by the probe user
space utility (maybe they were at one time?). So remove them.

Glenn

Glenn Washburn (4):
tests: Show host determined fs UUID when hfs UUID test fails
tests: Add /sbin and /usr/sbin to path in partmap test
formatting: Remove whitespace between N_ macro and open parenthesis util/probe.c: Remove unused header includes

 grub-core/commands/macbless.c | 6 ++----
 tests/partmap_test.in         | 2 ++
 tests/util/grub-fs-tester.in  | 2 +-
 util/probe.c                  | 2 --
 4 files changed, 5 insertions(+), 7 deletions(-)
Signature · 1 line
2.34.1