Skip to content

drm/i915: Media freq factor and per-gt enhancements/fixes

Ashutosh Dixit intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915/gt: Add media freq factor to per-gt sysfsdrivers/gpu/drm/i915/gt/intel_gt_regs.h drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c drivers/gpu/drm/i915/gt/uc/abi/guc_actions_slpc_abi.h +3 more+161 -00 replies
2/4drm/i915/pcode: Init pcode on different gt'sdrivers/gpu/drm/i915/i915_driver.c+18 -20 replies
3/4drm/i915/gt: Add media RP0/RPn to per-gt sysfsdrivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c drivers/gpu/drm/i915/i915_reg.h+55 -00 replies
4/4drm/i915/gt: Fix memory leaks in per-gt sysfsdrivers/gpu/drm/i915/gt/intel_gt.c drivers/gpu/drm/i915/gt/intel_gt_sysfs.c drivers/gpu/drm/i915/gt/intel_gt_sysfs.h +2 more+19 -220 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchTvrtko UrsulinAndi ShytiRodrigo ViviAndrzej Hajda
1/4R-b R-b
2/4R-b
3/4R-b
4/4R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [Intel-gfx] [PATCH 0/4] drm/i915: Media freq factor and per-gt enhancements/fixes

Some recent Intel dGfx platforms allow media IP to work at a different frequency from the base GT. This patch series exposes sysfs controls for this functionality in the new per-gt sysfs. Some enhancements and fixes to previous per-gt functionality are also included to complete the new functionality:
* Patches 1 and 2 implement basic sysfs controls for media freq
* Patch 3 extends previous pcode functions for multiple gt's
* Patch 4 inits pcode on different gt's
* Patch 5 adds a couple of pcode helpers
* Patch 6 uses the new pcode functions to retrieve media RP0/RPn freq
* Patch 7 fixes memory leaks in the previous per-gt sysfs implementation and some code refactoring

IGT tests for this new functionality have also been posted at:

https://patchwork.freedesktop.org/series/103175/

v2: Fixed commit author on patches 5 and 6 (Rodrigo)
Added new patch 4
v3: Expose pcode functions in terms of uncore rather than gt (Jani/Rodrigo)
v4: Retain previous pcode function names to eliminate
needless #defines (Rodrigo)
v5: Add new patch 4 and remove last two patches in the v4 series which will
be submitted later. Other mostly minor fixes from code review
v6: Identical to v5, only update "Test-with:" since CI did not pick up
previous "Test-with:" probably because it was old
v7: Rebase remaining patches after patches 1, 3 and 5 have been merged
v8-v10: CI retests, no code changes

Ashutosh Dixit (3):
drm/i915/gt: Add media freq factor to per-gt sysfs drm/i915/pcode: Init pcode on different gt's drm/i915/gt: Fix memory leaks in per-gt sysfs

Dale B Stimson (1):
drm/i915/gt: Add media RP0/RPn to per-gt sysfs

 drivers/gpu/drm/i915/gt/intel_gt.c            |   1 +
 drivers/gpu/drm/i915/gt/intel_gt_regs.h       |   1 +
 drivers/gpu/drm/i915/gt/intel_gt_sysfs.c      |  29 ++-
 drivers/gpu/drm/i915/gt/intel_gt_sysfs.h      |   6 +-
 drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c   | 177 ++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_gt_types.h      |   3 +
 .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h |   6 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c   |  20 ++
 drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h   |   1 +
 .../gpu/drm/i915/gt/uc/intel_guc_slpc_types.h |   3 +
 drivers/gpu/drm/i915/i915_driver.c            |  20 +-
 drivers/gpu/drm/i915/i915_reg.h               |   8 +
 drivers/gpu/drm/i915/i915_sysfs.c             |   2 +
 13 files changed, 253 insertions(+), 24 deletions(-)
Signature · 1 line
2.34.1