Skip to content

mptcp: mp_fail related fixes

Paolo Abeni mptcp 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 3 repliesIn review
  2. v46 patches 3 repliesSuperseded
  3. v36 patches 9 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v26 patches4 repliesSuperseded
v15 patches2 repliesSuperseded

Changes in v5 from the cover letter

- hopefully fix for real lockdep annotaiton in patch 6/6 (still mat)

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6mptcp: fix error mibs accountingnet/mptcp/options.c net/mptcp/pm.c net/mptcp/subflow.c+4 -70 replies
2/6mptcp: introduce MAPPING_BAD_CSUMnet/mptcp/subflow.c+9 -90 replies
3/6Squash-to: "mptcp: invoke MP_FAIL response when needed"net/mptcp/pm.c net/mptcp/protocol.c net/mptcp/protocol.h +1 more+74 -140 replies
4/6mptcp: fix shutdown vs fallback racenet/mptcp/options.c net/mptcp/protocol.c net/mptcp/protocol.h +1 more+19 -60 replies
5/6mptcp: consistent map handling on failurenet/mptcp/subflow.c+9 -100 replies
6/6mptcp: fix race on unaccepted mptcp socketsnet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+59 -01 reply

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMat Martineau
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 mptcp-net 0/6] mptcp: mp_fail related fixes

While cooking a follow-up for "mptcp: invoke MP_FAIL response when needed" I stumbled upon a few other MP_FAIL related issues hit my the self-tests while mangling the above.

All the patches for for the -net tree, and should be applied in-order around to the squashed-to patch.

v4 -> v5:
- hopefully fix for real lockdep annotaiton in patch 6/6 (still mat)

v3 -> v4:
- fix a couple of typos in 3/6, fix lockdep annotation in 6/6 (mat)

v2 -> v3:
- do not schedule mp_fail timeout on closed socket in patch 3/6 (mat)

v1 -> v2:
- take care of UaF in mptcp_worker with new patch 6/6

Paolo Abeni (6):
mptcp: fix error mibs accounting
mptcp: introduce MAPPING_BAD_CSUM
Squash-to: "mptcp: invoke MP_FAIL response when needed"
mptcp: fix shutdown vs fallback race
mptcp: consistent map handling on failure
mptcp: fix race on unaccepted mptcp sockets

 net/mptcp/options.c  |   8 +--
 net/mptcp/pm.c       |   5 +-
 net/mptcp/protocol.c |  57 ++++++++++++++++----
 net/mptcp/protocol.h |  25 +++++++--
 net/mptcp/subflow.c  | 121 +++++++++++++++++++++++++++++++++++--------
 5 files changed, 172 insertions(+), 44 deletions(-)
Signature · 1 line
2.35.3