Skip to content

drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c

Jani Nikula intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 2 repliesIn review
  2. v17 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/i915/wm: move wm state verification to intel_pm.cdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/intel_pm.c drivers/gpu/drm/i915/intel_pm.h+132 -1420 replies
2/11drm/i915/dpll: move shared dpll state verification to intel_dpll_mgr.cdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_dpll_mgr.c drivers/gpu/drm/i915/display/intel_dpll_mgr.h+95 -920 replies
3/11drm/i915/mpllb: use I915_STATE_WARN() for state mismatch warningsdrivers/gpu/drm/i915/display/intel_display.c+6 -80 replies
4/11drm/i915/mpllb: move mpllb state check to intel_snps_phy.cdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_snps_phy.c drivers/gpu/drm/i915/display/intel_snps_phy.h+48 -460 replies
5/11drm/i915/display: split out modeset verification codedrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h +2 more+284 -2350 replies
6/11drm/i915/display: split out crtc state dump to a separate filedrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_crtc_state_dump.c drivers/gpu/drm/i915/display/intel_crtc_state_dump.h +3 more+340 -3140 replies
7/11drm/i915/display: change who adds [] around crtc state dump context stringdrivers/gpu/drm/i915/display/intel_crtc_state_dump.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_modeset_verify.c+6 -60 replies
8/11drm/i915/display: rename dev_priv -> i915 in crtc state dumpdrivers/gpu/drm/i915/display/intel_crtc_state_dump.c+40 -400 replies
9/11drm/i915/display: split out hw state readout and sanitizedrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h +2 more+769 -7160 replies
10/11drm/i915/display: some struct drm_i915_private *i915 conversionsdrivers/gpu/drm/i915/display/intel_display.c+30 -300 replies
11/11drm/i915/display: convert modeset setup to struct drm_i915_private *i915drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_modeset_setup.c drivers/gpu/drm/i915/display/intel_modeset_setup.h+102 -1050 replies

Reviews trailers per patch

5 of 11 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchVille Syrjälä
SeriesR-b
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Intel-gfx] [PATCH v2 00/11] drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c

v2 of [1]. Address review comments, drop crtc state compare move, add hw state readout&sanitization split, and sprinkle some struct drm_i915_private *i915 cleanups on top.

BR,
Jani.

[1] https://patchwork.freedesktop.org/series/105156/

Jani Nikula (11):
drm/i915/wm: move wm state verification to intel_pm.c drm/i915/dpll: move shared dpll state verification to intel_dpll_mgr.c drm/i915/mpllb: use I915_STATE_WARN() for state mismatch warnings drm/i915/mpllb: move mpllb state check to intel_snps_phy.c drm/i915/display: split out modeset verification code drm/i915/display: split out crtc state dump to a separate file drm/i915/display: change who adds [] around crtc state dump context
string
drm/i915/display: rename dev_priv -> i915 in crtc state dump drm/i915/display: split out hw state readout and sanitize drm/i915/display: some struct drm_i915_private *i915 conversions drm/i915/display: convert modeset setup to struct drm_i915_private

    *i915
 drivers/gpu/drm/i915/Makefile                 |    3 +
 .../drm/i915/display/intel_crtc_state_dump.c  |  314 +++
 .../drm/i915/display/intel_crtc_state_dump.h  |   16 +
 drivers/gpu/drm/i915/display/intel_display.c  | 1680 +----------------
 drivers/gpu/drm/i915/display/intel_display.h  |   18 +
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |   88 +
 drivers/gpu/drm/i915/display/intel_dpll_mgr.h |    5 +
 .../drm/i915/display/intel_modeset_setup.c    |  724 +++++++
 .../drm/i915/display/intel_modeset_setup.h    |   15 +
 .../drm/i915/display/intel_modeset_verify.c   |  246 +++
 .../drm/i915/display/intel_modeset_verify.h   |   21 +
 drivers/gpu/drm/i915/display/intel_snps_phy.c |   43 +
 drivers/gpu/drm/i915/display/intel_snps_phy.h |    5 +-
 drivers/gpu/drm/i915/intel_pm.c               |  138 +-
 drivers/gpu/drm/i915/intel_pm.h               |   14 +-
 15 files changed, 1724 insertions(+), 1606 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.h
Signature · 1 line
2.30.2