Skip to content

cqe posting cleanups

Pavel Begunkov io-uring 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 16 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7io_uring: remove extra io_commit_cqring()io_uring/io_uring.c+0 -10 replies
2/7io_uring: reshuffle io_uring/io_uring.hio_uring/io_uring.h+47 -480 replies
3/7io_uring: move io_eventfd_signal()io_uring/io_uring.c+14 -160 replies
4/7io_uring: hide eventfd assumptions in evenfd pathsinclude/linux/io_uring_types.h io_uring/io_uring.c io_uring/timeout.c+29 -203 replies
5/7io_uring: remove ->flush_cqes optimisationio_uring/io_uring.c io_uring/io_uring.h+10 -158 replies
6/7io_uring: introduce locking helpers for CQE postingio_uring/io_uring.c io_uring/io_uring.h io_uring/timeout.c+36 -363 replies
7/7io_uring: add io_commit_cqring_flush()io_uring/io_uring.c io_uring/io_uring.h io_uring/rw.c+8 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH for-next 0/7] cqe posting cleanups

Apart from this patches removing some implicit assumptions, which we had problems with before, and making code cleaner, they and especially 6-7 are also needed to push for synchronisation optimisations later, lile
[1] or removing spinlocking with SINGLE_ISSUER.

The downside is that we add additional lock/unlock into eventfd path, but I don't think we care about it.

The series also exposes a minor issue with cancellations, which for some reason calls io_kill_timeouts() and io_poll_remove_all() too many times on task exit. That makes poll-cancel to timeout on sigalarm, though usually is fine if given 3-5 sec instead of 1. We'll investigate it later.

[1] https://github.com/isilence/linux/commit/6224f58bf7b542e6aed1eed44ee6bd5b5f706437

Pavel Begunkov (7):
io_uring: remove extra io_commit_cqring()
io_uring: reshuffle io_uring/io_uring.h
io_uring: move io_eventfd_signal()
io_uring: hide eventfd assumptions in evenfd paths
io_uring: remove ->flush_cqes optimisation
io_uring: introduce locking helpers for CQE posting
io_uring: add io_commit_cqring_flush()

 include/linux/io_uring_types.h |   2 +
 io_uring/io_uring.c            | 144 ++++++++++++++++-----------------
 io_uring/io_uring.h            | 108 ++++++++++++++-----------
 io_uring/rw.c                  |   5 +-
 io_uring/timeout.c             |   7 +-
 5 files changed, 133 insertions(+), 133 deletions(-)
Signature · 1 line
2.36.1