submit_bh: Drop unnecessary return value
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 2 repliesApplied
- v24 patches 3 repliesSuperseded
- v1 RFC3 patches 9 repliesSuperseded
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | jbd2: Drop useless return value of submit_bhfs/ fs/ | +8 | 0 replies | |
| 2/4 | fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_readfs/ | +2 | 0 replies | |
| 3/4 | fs/buffer: Drop useless return value of submit_bhfs/ | +4 | 1 reply | |
| 4/4 | fs/buffer: Make submit_bh & submit_bh_wbc return type as voidfs/ include/ | +7 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig | Jan Kara |
|---|---|---|
| 1/4 | R-b | R-b |
| 2/4 | R-b | R-b |
| 3/4 | R-b | |
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHv3 0/4] submit_bh: Drop unnecessary return value
submit_bh/submit_bh_wbc are non-blocking functions which just submits the bio and returns. The caller of submit_bh/submit_bh_wbc needs to wait on buffer till I/O completion and then check buffer head's b_state field to know if there was any I/O error.
Hence there is no need for these functions to have any return type. Even now they always returns 0. Hence drop the return value and make their return type as void to avoid any confusion.
PATCHv2 -> PATCHv3
===================
1. Rebased on top of the latest 6.0-rc1 release.
Recently REQ_OP_** req operations and REQ_** flags were combined as one parameter (blk_opf_t type) to submit_bh() API.
2. Since the patch series remains trivial on rebase, I have retained the reviewed-by from Jan and Christoph.
RFC -> PATCHv2
===============
1. Added Patch-2 to fix ntfs_submit_bh_for_read() caller.
2. Added Reviewed-by from Christoph.
Ritesh Harjani (IBM) (4):
jbd2: Drop useless return value of submit_bh
fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_read fs/buffer: Drop useless return value of submit_bh
fs/buffer: Make submit_bh & submit_bh_wbc return type as void
fs/buffer.c | 23 ++++++++++------------- fs/jbd2/commit.c | 10 ++++------ fs/jbd2/journal.c | 9 ++++----- fs/ntfs/file.c | 4 ++-- include/linux/buffer_head.h | 2 +- 5 files changed, 21 insertions(+), 27 deletions(-)
--
2.35.3