Skip to content

KVM: x86/mmu: Fix wrong usages of range-based tlb flushing

Hou Wenlong kvm lkml 4 versions – Applied

Status from this message: Applied to kvm-x86 mmu, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 5 repliesApplied
  2. v36 patches 2 repliesSuperseded
  3. v26 patches 18 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches8 repliesSuperseded

Changes in v4 from the cover letter

- Move patch 1 after kvm_flush_remote_tlbs_sptep() is introduced, Drop kvm_flush_remote_tlbs_direct_sp() helper and use kvm_flush_remote_tlbs_sptep() instead.
- Wrap changelogs at ~75 chars.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/6KVM: x86/mmu: Move round_gfn_for_level() helper into mmu_internal.harch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/mmu_internal.h arch/x86/kvm/mmu/paging_tmpl.h +1 more+12 -110 replies
2/6KVM: x86/mmu: Fix wrong gfn range of tlb flushing in kvm_set_pte_rmapp()arch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/mmu_internal.h+13 -13 replies
3/6KVM: x86/mmu: Reduce gfn range of tlb flushing in tdp_mmu_map_handle_target_level()arch/x86/kvm/mmu/tdp_mmu.c+1 -20 replies
4/6KVM: x86/mmu: Fix wrong start gfn of tlb flushing with rangearch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/paging_tmpl.h+15 -80 replies
5/6KVM: x86/mmu: Fix wrong gfn range of tlb flushing in validate_direct_spte()arch/x86/kvm/mmu/mmu.c+1 -10 replies
6/6KVM: x86/mmu: Cleanup range-based flushing for given pagearch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/tdp_mmu.c+3 -50 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchDavid Matlack
1/6
2/6
3/6R-b
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] KVM: x86/mmu: Fix wrong usages of range-based tlb flushing

Commit c3134ce240eed ("KVM: Replace old tlb flush function with new one to flush a specified range.") replaces old tlb flush function with kvm_flush_remote_tlbs_with_address() to do tlb flushing. However, the gfn range of tlb flushing is wrong in some cases. E.g., when a spte is dropped, the start gfn of tlb flushing should be the gfn of spte not the base gfn of SP which contains the spte. Although, as Paolo said, Hyper-V may treat a 1-page flush the same if the address points to a huge page, and no fixes are reported so far. So it seems that it works well for Hyper-V. But it would be better to use the correct size for huge page. So this patchset would fix them and introduce some helper functions as David suggested to make the code clear.

Changed from v3:
- Move patch 1 after kvm_flush_remote_tlbs_sptep() is introduced, Drop kvm_flush_remote_tlbs_direct_sp() helper and use kvm_flush_remote_tlbs_sptep() instead.
- Wrap changelogs at ~75 chars.

Changed from v2:
- Introduce kvm_flush_remote_tlbs_gfn() in Patch 1 early.
- Move round_gfn_for_level() in tdp_iter.c into mmu_internal.h for common usage and cleanup the call sites of rounding down the GFN.
- Drop Patch 6.

Changed from v1:
- Align down gfn in kvm_set_pte_rmapp() instead of change iterator->gfn in rmap_walk_init_level() in Patch 2.
- Introduce some helper functions for common operations as David suggested.

v3: https://lore.kernel.org/kvm/[email protected]

Hou Wenlong (6):
KVM: x86/mmu: Move round_gfn_for_level() helper into mmu_internal.h
KVM: x86/mmu: Fix wrong gfn range of tlb flushing in

    kvm_set_pte_rmapp()

KVM: x86/mmu: Reduce gfn range of tlb flushing in
tdp_mmu_map_handle_target_level()
KVM: x86/mmu: Fix wrong start gfn of tlb flushing with range
KVM: x86/mmu: Fix wrong gfn range of tlb flushing in
validate_direct_spte()
KVM: x86/mmu: Cleanup range-based flushing for given page

 arch/x86/kvm/mmu/mmu.c          | 36 +++++++++++++++++++++------------
 arch/x86/kvm/mmu/mmu_internal.h | 15 ++++++++++++++
 arch/x86/kvm/mmu/paging_tmpl.h  |  5 ++---
 arch/x86/kvm/mmu/tdp_iter.c     | 11 +++-------
 arch/x86/kvm/mmu/tdp_mmu.c      |  6 ++----
 5 files changed, 45 insertions(+), 28 deletions(-)

--
2.31.1