Skip to content

Staging: rtl8192e: rtllib_wx

Felix Schlepper linux-staging lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 7 repliesIn review
  2. v26 patches 1 replySuperseded

Changes in v3 from the cover letter

- Fixed a checkpatch.pl warning, which was introduced with patch 1/6.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6Staging: rtl8192e: Refactored rtllib_modesdrivers/staging/rtl8192e/rtllib_wx.c+6 -151 reply
2/6Staging: rtl8192e: Avoid multiple assignmentsdrivers/staging/rtl8192e/rtllib_wx.c+2 -11 reply
3/6Staging: rtl8192e: Remove unnecessary parenthesesdrivers/staging/rtl8192e/rtllib_wx.c+2 -21 reply
4/6Staging: rtl8192e: Added braces around elsedrivers/staging/rtl8192e/rtllib_wx.c+4 -21 reply
5/6Staging: rtl8192e: Remove unnecessary blank linedrivers/staging/rtl8192e/rtllib_wx.c+0 -11 reply
6/6Staging: rtl8192e: Added spaces around '+'drivers/staging/rtl8192e/rtllib_wx.c+1 -11 reply

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchPhilipp Hortmann
SeriesT-b
1/6T-b
2/6T-b
3/6T-b
4/6T-b
5/6T-b
6/6T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] Staging: rtl8192e: rtllib_wx

This series addresses some issues raised by chechpatch.pl and some very minor refactoring.

v2:
- The first version, only addressed coding style issues. Now, I additionally refactored rtllib_modes and its uses, since there is no need to use string formatting.
- Logically separated one assignement into two. So we dont have 'fixed' = 'disabled', which was silly.

v3:
- Fixed a checkpatch.pl warning, which was introduced with patch 1/6.

Felix Schlepper (6):
Staging: rtl8192e: Refactored rtllib_modes
Staging: rtl8192e: Avoid multiple assignments
Staging: rtl8192e: Remove unnecessary parentheses
Staging: rtl8192e: Added braces around else
Staging: rtl8192e: Remove unnecessary blank line
Staging: rtl8192e: Added spaces around '+'

 drivers/staging/rtl8192e/rtllib_wx.c | 37 +++++++++++-----------------
 1 file changed, 15 insertions(+), 22 deletions(-)
Signature · 1 line
2.36.1