Skip to content

drm/i915: Apply waitboosting before fence wait

Karolina Drobnik intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 8 repliesIn review
  2. v13 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Fixed a style issue in i915_gem_object_boost

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/i915/gem: Look for waitboosting across the whole object prior to individual waitsdrivers/gpu/drm/i915/gem/i915_gem_wait.c+34 -01 reply
2/3drm/i915: Bump GT idling delay to 2 jiffiesdrivers/gpu/drm/i915/i915_active.c+1 -10 replies
3/3drm/i915/gt: Only kick the signal worker if there's been an updatedrivers/gpu/drm/i915/gt/intel_breadcrumbs.c+2 -15 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchThomas VoegtleAndi ShytiRodrigo Vivi
1/3T-b R-b A-b
2/3R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [Intel-gfx] [PATCH v2 0/3] drm/i915: Apply waitboosting before fence wait

Waitboost is a heuristic that detects latency sensitive workloads waiting for the results from previous execution. The wait can be seen as GPU under-utilisation by RPS, Render Power State management, which might lower the GPU frequency to save power. Limiting the frequency means more waiting for results, which is undesirable for submissions with tight time constraints. To circumvent this, with waitboost we iteratively check the list of fences during gem_wait to see if any of them is stalled waiting for GPU. If such is found, and the request hasn't yet started its execution, we temporarily bump up the GPU frequency, so we get the required results as soon as possible.

Commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") changes the fences order and how they are iterated. Under this new scheme, we would wait on each fence that starts executing, rendering them not suitable for waitboost.

To avoid situation like this, inspect the entire list of fences dma-resv earlier, before gem_wait, instead of sequentially waiting for each of them, applying the boost when needed.

v2:
- Fixed a style issue in i915_gem_object_boost

Chris Wilson (3):
drm/i915/gem: Look for waitboosting across the whole object prior to
individual waits
drm/i915: Bump GT idling delay to 2 jiffies
drm/i915/gt: Only kick the signal worker if there's been an update

 drivers/gpu/drm/i915/gem/i915_gem_wait.c    | 34 +++++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c |  3 +-
 drivers/gpu/drm/i915/i915_active.c          |  2 +-
 3 files changed, 37 insertions(+), 2 deletions(-)

--
2.25.1