Skip to content

btrfs: a few direct IO fixes/improvements

[email protected] linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: return -EAGAIN for NOWAIT dio reads/writes on compressed and inline extentsfs/btrfs/inode.c+13 -12 replies
2/3btrfs: don't fallback to buffered IO for NOWAIT direct IO writesfs/btrfs/file.c+15 -15 replies
3/3btrfs: fault in pages for dio reads/writes in a more controlled wayfs/btrfs/file.c+40 -160 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchDominique MARTINETChristoph Hellwig
1/3T-b R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] btrfs: a few direct IO fixes/improvements

From: Filipe Manana <[email protected]>

Several fixes and improvements regarding direct IO, with the first one being recently reported by Dominique when using qemu with io_uring on images that have a mix of compressed and non-compressed extents. That in particular exposed a bug in qemu's handling of partial reads, fixed recently by Dominique, but despite that we could avoid returning a partial read when there's really no need to, not just for efficiency but also because many applications don't take into consideration partial reads (MariaDB for example didn't use to until recently) or are buggy dealing with them. More details in the changelogs.

Filipe Manana (3):
btrfs: return -EAGAIN for NOWAIT dio reads/writes on compressed and
inline extents
btrfs: don't fallback to buffered IO for NOWAIT direct IO writes
btrfs: fault in pages for dio reads/writes in a more controlled way

 fs/btrfs/file.c  | 72 ++++++++++++++++++++++++++++++++++++------------
 fs/btrfs/inode.c | 14 +++++++++-
 2 files changed, 68 insertions(+), 18 deletions(-)
Signature · 1 line
2.35.1