Skip to content

pack-bitmap.c: optimize error messages

tenglong.tl git 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest6 patches 2 repliesIn review
  2. v77 patches 9 repliesSuperseded
  3. v67 patches 12 repliesSuperseded

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6pack-bitmap.c: fix formatting of error messagespack-bitmap.c+24 -230 replies
2/6pack-bitmap.c: mark more strings for translationspack-bitmap.c+24 -240 replies
3/6pack-bitmap.c: rename "idx_name" to "bitmap_name"pack-bitmap.c+7 -70 replies
4/6pack-bitmap.c: do not ignore error when opening a bitmap filepack-bitmap.c+12 -50 replies
5/6pack-bitmap.c: using error() instead of silently returning -1pack-bitmap.c+5 -10 replies
6/6pack-bitmap.c: continue looping when first MIDX bitmap is foundpack-bitmap.c+3 -20 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchTaylor Blau
1/6
2/6
3/6
4/6
5/6
6/6Helped-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/6] pack-bitmap.c: optimize error messages

From: Teng Long <[email protected]>

Changes since v7:

Remove [7/7] and will move to another separate topic.

Thanks.

Teng Long (6):
pack-bitmap.c: fix formatting of error messages pack-bitmap.c: mark more strings for translations pack-bitmap.c: rename "idx_name" to "bitmap_name" pack-bitmap.c: do not ignore error when opening a bitmap file pack-bitmap.c: using error() instead of silently returning -1 pack-bitmap.c: continue looping when first MIDX bitmap is found

 pack-bitmap.c | 103 ++++++++++++++++++++++++++++----------------------
 1 file changed, 58 insertions(+), 45 deletions(-)

Range-diff against v7:

1:  a01ae8478d < -:  ---------- tr2: dump names if config exist in multiple scopes
-:  ---------- > 1:  7426b277ba pack-bitmap.c: fix formatting of error messages
-:  ---------- > 2:  4e493426a0 pack-bitmap.c: mark more strings for translations
-:  ---------- > 3:  263f45ba96 pack-bitmap.c: rename "idx_name" to "bitmap_name"
-:  ---------- > 4:  d11ea092d5 pack-bitmap.c: do not ignore error when opening a bitmap file
-:  ---------- > 5:  f60efe78d6 pack-bitmap.c: using error() instead of silently returning -1
-:  ---------- > 6:  83090308ad pack-bitmap.c: continue looping when first MIDX bitmap is found
Signature · 1 line
2.35.0.rc0.679.gc613175da2