btrfs-progs: separate BLOCK_GROUP_TREE feature from extent-tree-v2
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | btrfs-progs: mkfs: dynamically modify mkfs blocks arraymkfs/ mkfs/ | +69 | 0 replies | |
| 2/3 | btrfs-progs: don't save block group root into super blockcmds/ kernel-shared/ kernel-shared/ +2 more | +20 | 0 replies | |
| 3/3 | btrfs-progs: separate block group tree from extent tree v2check/ common/ common/ +6 more | +51 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] btrfs-progs: separate BLOCK_GROUP_TREE feature from extent-tree-v2
The block group tree idea is introduced to greatly reduce mount time for large fs, over SEVERN years ago.
And 4 years ago, it's determined to let extent-tree-v2 to implement the feature.
However extent tree v2 still doesn't have a consistent on-disk format, nor any implementation on the real extent items, nor any tests on some independent sub-features.
I strongly doubt if that's a correct decision, especially considering there is really no dependency from extent tree v2 on this block group tree feature.
Not to mention this is against the common idea on progressive improvement.
So now is the time to revive the independent block group compat RO flag.
[CHANGE FROM EXTENT-TREE-V2]
- Don't store block group root into super block
There is no special reason for block group root to be stored in super block.
- Separate block-group-tree as a compat RO flag from extent-tree-v2 The change to extent tree is not affecting read-only opeartions. No reason to make it incompat.
- Fix a bug in extent-tree-v2 which doesn't initialize block group item correctly.
Since we're re-using the existing block group item structure, we should properly initialize chunk_objectid to 256, or tree block will reject it.
- Dynamically arrange the mkfs_block array
Instead a completely new array dedicated for extent-tree-v2, now we have proper helpers to add/delete block from the array on-the-fly.
[TODO]
- Add btrfstune support to convert to block-group-tree feature and back.
This is supported in previous push, but now due to the new changes introduced by extent-tree-v2, I need to revisit the convert tool.
And due to recent inspirations from csum conversion, I will go the double tree co-exist method to do the conversion, instead of the old one transaction conversion.
Qu Wenruo (3):
btrfs-progs: mkfs: dynamically modify mkfs blocks array
btrfs-progs: don't save block group root into super block
btrfs-progs: separate block group tree from extent tree v2
check/main.c | 8 +-- cmds/inspect-dump-tree.c | 11 ---- common/fsfeatures.c | 8 +++ common/fsfeatures.h | 2 + kernel-shared/ctree.h | 35 +++--------- kernel-shared/disk-io.c | 77 ++++++------------------- kernel-shared/disk-io.h | 2 +- kernel-shared/print-tree.c | 11 +--- mkfs/common.c | 113 ++++++++++++++++++++++++++++++------- mkfs/common.h | 20 +------ mkfs/main.c | 3 +- 11 files changed, 138 insertions(+), 152 deletions(-)
Signature · 1 line
2.37.0