Skip to content

drm/i915/gt: Expose per gt defaults in sysfs

Ashutosh Dixit dri-devel intel-gfx 1 version Applied

Status from this message: Pushed to drm-intel-gt-next. Thanks for the patches.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2drm/i915/gt: Create gt/gtN/.defaults/ for per gt sysfs defaultsdrivers/gpu/drm/i915/gt/intel_gt_sysfs.c drivers/gpu/drm/i915/gt/intel_gt_types.h+12 -00 replies
2/2drm/i915/gt: Expose per-gt RPS defaults in sysfsdrivers/gpu/drm/i915/gt/intel_gt_sysfs.c drivers/gpu/drm/i915/gt/intel_gt_sysfs.h drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +3 more+52 -90 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRodrigo Vivi
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] drm/i915/gt: Expose per gt defaults in sysfs

Create a gt/gtN/.defaults/ directory (similar to engine/<engine-name>/.defaults/) to expose default parameter values for each gt in sysfs. This allows userspace to restore default parameter values after they may have changed.

Patch 1: Creates the gt/gtN/.defaults/ directory
Patch 2: Adds per-gt RPS defaults (rps_max_freq_mhz and rps_min_freq_mhz)
to gt/gtN/.defaults/

An approved Level-0/oneAPI UMD pull request which consumes the exposed defaults can be seen here:
https://github.com/intel/compute-runtime/pull/552
The UMD pull request will be merged if/after this series is merged to i915.

Previous discussion on these patches can be seen here:

	https://patchwork.freedesktop.org/patch/484238/?series=102665&rev=4
	https://patchwork.freedesktop.org/patch/483988/?series=102665&rev=3
Cc Matt Roper <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
Cc Andi Shyti <[email protected]>

Ashutosh Dixit (2):
drm/i915/gt: Create gt/gtN/.defaults/ for per gt sysfs defaults drm/i915/gt: Expose per-gt RPS defaults in sysfs

 drivers/gpu/drm/i915/gt/intel_gt_sysfs.c    | 10 +++---
 drivers/gpu/drm/i915/gt/intel_gt_sysfs.h    |  6 ++++
 drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 34 +++++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_gt_types.h    |  9 ++++++
 drivers/gpu/drm/i915/gt/intel_rps.c         |  2 ++
 drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 12 +++++---
 6 files changed, 64 insertions(+), 9 deletions(-)
Signature · 1 line
2.34.1