tests/gem_exec_fence: Fix test_fence_await for hanging workloads
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 14 repliesIn review
- v12 patches 8 repliesSuperseded
Changes in v2 from the cover letter
No functional changes, fixed styling issues pointed out by Kamil:
- Moved comment for fence_busy(spin->out_fence) assertion
- Fixed formatting for flags assignment in spin definition
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | tests/gem_exec_fence: Check stored values only for valid workloadstests/ | +8 | 6 replies | |
| 2/2 | tests/gem_exec_fence: Coordinate sleep with the start of the requesttests/ | +4 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Kamil Konieczny |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [igt-dev] [PATCH i-g-t v2 0/2] tests/gem_exec_fence: Fix test_fence_await for hanging workloads
This patch series fixes test_fence_await for failing gem_exec_fence subtests that inject GPU hangs (await-hang and nb-await-hang). The test assumed that the error notification happens after a hang is declared, which would be enough for the next set of fences to be submitted, making this test pass. But as we use the error-interrupt, we get immediate reset for the invalid command stream. This means that when the test checks for active fences, none can be found, leading to the test failure.
To address this problem, the active fences check is only done for valid workloads. In addition to the fix, the series adds spinning before usleep() call to coordinate sleep with the start of the request.
v2:
No functional changes, fixed styling issues pointed out by Kamil:
- Moved comment for fence_busy(spin->out_fence) assertion
- Fixed formatting for flags assignment in spin definition
Chris Wilson (2):
tests/gem_exec_fence: Check stored values only for valid workloads tests/gem_exec_fence: Coordinate sleep with the start of the request
tests/i915/gem_exec_fence.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-)
--
2.25.1