Skip to content

tr2: shows the scope unconditionally with config

Teng Long git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v10 of 2 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2api-trace2.txt: print config key-value pairDocumentation/technical/api-trace2.txt+31 -00 replies
2/2tr2: shows scope unconditionally in addition to key-value pairDocumentation/technical/api-trace2.txt trace2/tr2_tgt_event.c trace2/tr2_tgt_normal.c +1 more+27 -71 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] tr2: shows the scope unconditionally with config

From: Teng Long <[email protected]>

Diff from v1:

* Fix the premature code in [1/2] by Junio's comment in:

https://public-inbox.org/git/[email protected]/

* Optimize the documentaion in [1/2] by Ævar's comment in:

https://public-inbox.org/git/[email protected]/

I send this patch version a little earlier maybe because some context not fully discussed or solved, intend to avoid context signal disappearance because it's been lasted a while now.

Thanks.

Teng Long (2):
api-trace2.txt: print config key-value pair
tr2: shows scope unconditionally in addition to key-value pair

 Documentation/technical/api-trace2.txt | 40 ++++++++++++++++++++++++++
 trace2/tr2_tgt_event.c                 |  3 ++
 trace2/tr2_tgt_normal.c                |  5 +++-
 trace2/tr2_tgt_perf.c                  |  9 ++++--
 4 files changed, 54 insertions(+), 3 deletions(-)

Range-diff against v1:
1: bebd97c832 ! 1: 84bd8a71d7 api-trace2.txt: print config key-value pair
@@ Documentation/technical/api-trace2.txt: at offset 508.
This example also shows that thread names are assigned in a racy manner as each thread starts and allocates TLS storage.

-+Print Configs::
++Config (def param) Events::
+
+ Dump "interesting" config values to trace2 log.
++
-+The environment variable GIT_TRACE2_CONFIG_PARAMS and configuration -+trace2.configparams can be used to output config values which you care -+about(see linkgit:git-config[1). For example:
++We can optionally emit configuration events, see
++trace2.configparams in linkgit:git-config[1] for how to enable
++it.
++
+----------------
+$ git config color.ui auto
2: 2f8fce6599 ! 2: 9856058df6 tr2: shows scope unconditionally in addition to key-value pair
@@ Documentation/technical/api-trace2.txt: The "exec_id" field is a command-unique
{
"event":"def_param",
...
-+ scope: <a string that 'git config --show-scope' would return>
++ "scope":"global",
"param":"core.abbrev",
"value":"7"
}
-@@ Documentation/technical/api-trace2.txt: Print Configs::
- +
- The environment variable GIT_TRACE2_CONFIG_PARAMS and configuration
- trace2.configparams can be used to output config values which you care --about(see linkgit:git-config[1). For example:
-+about(see linkgit:git-config[1). For example assume that we want to config -+different color.ui values in multiple scopes, such as:
+@@ Documentation/technical/api-trace2.txt: We can optionally emit configuration events, see
+ it.
+
----------------
-$ git config color.ui auto

Signature · 1 line
2.37.1.1.g8cbb44ffc4.dirty