Skip to content

CXL XOR Interleave Arithmetic

[email protected] linux-cxl 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest3 patches 4 repliesIn review
  2. v83 patches 4 repliesSuperseded
  3. v73 patches 0 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v63 patches4 repliesSuperseded
v53 patches3 repliesSuperseded
v43 patches3 repliesSuperseded
v33 patches1 replySuperseded
v22 patches1 replySuperseded
v12 patches4 repliesSuperseded

Changes in v9 from the cover letter

- Add Jonathan's Reviewed-by tags to Patches 2/3
- Move calc of n to separate func (Jonathan)
- Use ways_to_cxl() for self-documentation, despite overkill (Jonathan)
- Use the #define ACPI_CEDT_CFMWS_ARITHMETIC_XOR in cxl_test (Jonathan)
- Tidy up whitespace and trailing commas (Jonathan)
*I went w trailing commas, because we should always expect more :)

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ACPICA commit 2d8dc0383d3c908389053afbdc329bbd52f009ceinclude/acpi/actbl1.h+34 -10 replies
2/3cxl/acpi: Support CXL XOR Interleave Math (CXIMS)drivers/cxl/acpi.c drivers/cxl/core/port.c drivers/cxl/cxl.h+148 -82 replies
3/3tools/testing/cxl: Add XOR Math support to cxl_testtools/testing/cxl/test/cxl.c+115 -32 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchJonathan Cameron
1/3
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 0/3] CXL XOR Interleave Arithmetic

From: Alison Schofield <[email protected]>

Add support for the new 'XOR' Interleave Arithmetic as defined in the CXL 3.0 Specification:
https://www.computeexpresslink.org/download-the-specification

Changes in v9:
- Add Jonathan's Reviewed-by tags to Patches 2/3
- Move calc of n to separate func (Jonathan)
- Use ways_to_cxl() for self-documentation, despite overkill (Jonathan)
- Use the #define ACPI_CEDT_CFMWS_ARITHMETIC_XOR in cxl_test (Jonathan)
- Tidy up whitespace and trailing commas (Jonathan)
*I went w trailing commas, because we should always expect more :)

Changes in v8:
- Move typedef of cxl_cal_hb_fn in cxl.h earlier for use in cxl_root_decoder (It's a bit soon, and a bit small, for rev'ing without awaiting review, but want this to be in sync with the address translation patchset that follows.)

Changes in v7:
- Set calc_hb only once (DavidL, Dan)
- Refactor to eliminate the decoder_add goto (DavidL)
- dev_err() and fail on unknown interleave arithmetic (DavidL)
- Add NULL check after devm_zalloc() of cximsd (DavidL)
- Rename struct cxims_data cxl_cxims_data

Changes in v6:
- Rebase on 6.1-rc4, merging with Dan's latest cxl_test work.
- ACPI patch is now the 'official' linuxized version, not yet merged.

Changes in v5:
- Add to 'n' for 6 & 12 way. (v3->v4 broke it)
- Clean up x3 index init. (Dan)
- Remove unneeded HB's from cxl_test topology.
- Remove dependency on stale patch in cxl_test.

Changes in v4:
- Use GENMASK_ULL to fix i386 arch build (0-day)
- Use do_div to fix ARM arch build (0-day)
- Update comments in ACPICA patch to reflect new state of the ACPICA patch - pending again in github.

Changes in v3:
- Fix the 3, 6, 12 way interleave (again).
- Do not look for a CXIMS when not needed for x1 & x3 interleaves
- New cxl_test patch: Add cxl_test module support for this feature
- In a separate ndctl patch, cxl test: cxl_xor_region is added

Changes in v2:
- Use ilog2() of the decoded interleave ways to determine number of xormaps, instead of using encoded ways directly. This fixes 3, 6, and 12 way interleaves. (Dan)

Alison Schofield (3):
ACPICA commit 2d8dc0383d3c908389053afbdc329bbd52f009ce cxl/acpi: Support CXL XOR Interleave Math (CXIMS) tools/testing/cxl: Add XOR Math support to cxl_test

 drivers/cxl/acpi.c           | 136 ++++++++++++++++++++++++++++++++++-
 drivers/cxl/core/port.c      |   9 ++-
 drivers/cxl/cxl.h            |  11 ++-
 include/acpi/actbl1.h        |  35 ++++++++-
 tools/testing/cxl/test/cxl.c | 118 +++++++++++++++++++++++++++++-
 5 files changed, 297 insertions(+), 12 deletions(-)

base-commit: f0c4d9fc9cc9462659728d168387191387e903cc

Signature · 1 line
2.37.3