mlxsw: Fixes for PTP support
Status from this message: This series was applied to netdev/net.git (master)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 4 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | mlxsw: spectrum_ptp: Fix compilation warningsdrivers/ | +10 | 0 replies | Applied |
| 2/4 | mlxsw: spectrum: Clear PTP configuration after unregistering the netdevicedrivers/ | +1 | 0 replies | Applied |
| 3/4 | mlxsw: spectrum_ptp: Protect PTP configuration with a mutexdrivers/ | +20 | 0 replies | Applied |
| 4/4 | mlxsw: spectrum_ptp: Forbid PTP enablement only in RX or in TXdrivers/ | +3 | 0 replies | Applied |
Reviews trailers per patch
2 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Petr Machata |
|---|---|
| 1/4 | R-b |
| 2/4 | |
| 3/4 | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net 0/4] mlxsw: Fixes for PTP support
This set fixes several issues in mlxsw PTP code.
- Patch #1 fixes compilation warnings.
- Patch #2 adjusts the order of operation during cleanup, thereby closing the window after PTP state was already cleaned in the ASIC for the given port, but before the port is removed, when the user could still in theory make changes to the configuration.
- Patch #3 protects the PTP configuration with a custom mutex, instead of relying on RTNL, which is not held in all access paths.
- Patch #4 forbids enablement of PTP only in RX or only in TX. The driver implicitly assumed this would be the case, but neglected to sanitize the configuration.
Amit Cohen (4):
mlxsw: spectrum_ptp: Fix compilation warnings
mlxsw: spectrum: Clear PTP configuration after unregistering the
netdevice
mlxsw: spectrum_ptp: Protect PTP configuration with a mutex
mlxsw: spectrum_ptp: Forbid PTP enablement only in RX or in TX
.../net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- .../ethernet/mellanox/mlxsw/spectrum_ptp.c | 30 ++++++++++++++----- .../ethernet/mellanox/mlxsw/spectrum_ptp.h | 18 ++++++----- 3 files changed, 34 insertions(+), 16 deletions(-)
Signature · 1 line
2.35.3