Skip to content

btrfs: some updates to delayed items and inode logging

[email protected] linux-btrfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 1 replyIn review
  2. v115 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15btrfs: don't drop dir index range items when logging a directoryfs/btrfs/tree-log.c+1 -50 replies
2/15btrfs: remove the root argument from log_new_dir_dentries()fs/btrfs/tree-log.c+3 -30 replies
3/15btrfs: update stale comment for log_new_dir_dentries()fs/btrfs/tree-log.c+4 -40 replies
4/15btrfs: free list element sooner at log_new_dir_dentries()fs/btrfs/tree-log.c+30 -220 replies
5/15btrfs: avoid memory allocation at log_new_dir_dentries() for common casefs/btrfs/tree-log.c+12 -170 replies
6/15btrfs: remove root argument from btrfs_delayed_item_reserve_metadata()fs/btrfs/delayed-inode.c+3 -50 replies
7/15btrfs: store index number instead of key in struct btrfs_delayed_itemfs/btrfs/delayed-inode.c fs/btrfs/delayed-inode.h+56 -530 replies
8/15btrfs: remove unused logic when looking up delayed itemsfs/btrfs/delayed-inode.c+3 -420 replies
9/15btrfs: shrink the size of struct btrfs_delayed_itemfs/btrfs/delayed-inode.c fs/btrfs/delayed-inode.h+25 -240 replies
10/15btrfs: search for last logged dir index if it's not cached in the inodefs/btrfs/tree-log.c+74 -450 replies
11/15btrfs: move need_log_inode() to above log_conflicting_inodes()fs/btrfs/tree-log.c+35 -350 replies
12/15btrfs: move log_new_dir_dentries() above btrfs_log_inode()fs/btrfs/tree-log.c+167 -1670 replies
13/15btrfs: log conflicting inodes without holding log mutex of the initial inodefs/btrfs/file.c fs/btrfs/tree-log.c fs/btrfs/tree-log.h+196 -1520 replies
14/15btrfs: skip logging parent dir when conflicting inode is not a dirfs/btrfs/tree-log.c+62 -100 replies
15/15btrfs: use delayed items when logging a directoryfs/btrfs/delayed-inode.c fs/btrfs/delayed-inode.h fs/btrfs/tree-log.c +1 more+562 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/15] btrfs: some updates to delayed items and inode logging

From: Filipe Manana <[email protected]>

This patchset brings some optimizations to inode logging, especially for logging directories, but also when logging a regular file that happens to have the name of another file that was previously deleted in the current transaction (triggered very often by the workloads simulated by dbench). It brings along some cleanups to delated items and logging in general too. More details in the changelogs of the patches. Thanks.

V2: Updated patch 10/15, added some comments and removed some code made
obsolete by it.
Updated patch 15/15 to make sure recursion of btrfs_log_inode() is bounded to happen at most once when we have new subdirectories.

Filipe Manana (15):
btrfs: don't drop dir index range items when logging a directory
btrfs: remove the root argument from log_new_dir_dentries()
btrfs: update stale comment for log_new_dir_dentries()
btrfs: free list element sooner at log_new_dir_dentries()
btrfs: avoid memory allocation at log_new_dir_dentries() for common case
btrfs: remove root argument from btrfs_delayed_item_reserve_metadata()
btrfs: store index number instead of key in struct btrfs_delayed_item
btrfs: remove unused logic when looking up delayed items
btrfs: shrink the size of struct btrfs_delayed_item
btrfs: search for last logged dir index if it's not cached in the inode
btrfs: move need_log_inode() to above log_conflicting_inodes()
btrfs: move log_new_dir_dentries() above btrfs_log_inode()
btrfs: log conflicting inodes without holding log mutex of the initial inode
btrfs: skip logging parent dir when conflicting inode is not a dir
btrfs: use delayed items when logging a directory

 fs/btrfs/delayed-inode.c |  292 +++++---
 fs/btrfs/delayed-inode.h |   34 +-
 fs/btrfs/file.c          |    1 +
 fs/btrfs/tree-log.c      | 1418 ++++++++++++++++++++++++++------------
 fs/btrfs/tree-log.h      |    8 +
 5 files changed, 1197 insertions(+), 556 deletions(-)
Signature · 1 line
2.35.1