Skip to content

ppc4xx_sdram QOMify and clean ups

BALATON Zoltan qemu-devel 7 versions – Applied

Status from this message: Queued in gitlab.com/danielhb/qemu/tree/ppc-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest8 patches 8 repliesApplied
  2. v625 patches 20 repliesSuperseded
  3. v521 patches 6 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v421 patches7 repliesSuperseded
v320 patches20 repliesSuperseded
v218 patches1 replySuperseded
v120 patches29 repliesSuperseded

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/8ppc440_uc.c: Move DDR2 SDRAM controller model to ppc4xx_sdram.chw/ppc/meson.build hw/ppc/ppc440_uc.c hw/ppc/ppc4xx_sdram.c+350 -3333 replies
2/8ppc4xx_devs.c: Move DDR SDRAM controller model to ppc4xx_sdram.chw/ppc/ppc4xx_devs.c hw/ppc/ppc4xx_sdram.c+365 -3521 reply
3/8ppc4xx_sdram: Move ppc4xx_sdram_banks() to ppc4xx_sdram.chw/ppc/ppc4xx_devs.c hw/ppc/ppc4xx_sdram.c include/hw/ppc/ppc4xx.h+69 -741 reply
4/8ppc4xx_sdram: Use hwaddr for memory bank sizehw/ppc/ppc4xx_sdram.c+4 -100 replies
5/8ppc4xx_sdram: Rename local state variable for brevityhw/ppc/ppc4xx_sdram.c+79 -790 replies
6/8ppc4xx_sdram: Generalise bank setuphw/ppc/ppc4xx_sdram.c hw/ppc/trace-events+48 -441 reply
7/8ppc4xx_sdram: Convert DDR SDRAM controller to new bank handlinghw/ppc/ppc4xx_sdram.c+37 -611 reply
8/8ppc4xx_sdram: Add errp parameter to ppc4xx_sdram_banks()hw/ppc/ppc4xx_sdram.c+19 -90 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéDaniel Henrique Barboza
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/8] ppc4xx_sdram QOMify and clean ups

This is the end of the QOMify series originially started by Cédric rebased on master now only including patches not yet merged. Patches that still need review are 1-3 (these only move code to ppc4xx_sdram.c) and 6-7 (unify DDR and DDR2 models to share code where possible).

Regards,
BALATON Zoltan

v7: Rebase on master after merge of first part of the series
v6: Split patch moving sdram controller models together into smaller steps
v5: Add functions the enable sdram controller and call it from boards
v4: address more review comments
v3: Fix patches that got squashed during rebase
v2: address some review comments and try to avoid compile problem with gcc 12.2 (untested)

BALATON Zoltan (8):
ppc440_uc.c: Move DDR2 SDRAM controller model to ppc4xx_sdram.c ppc4xx_devs.c: Move DDR SDRAM controller model to ppc4xx_sdram.c
ppc4xx_sdram: Move ppc4xx_sdram_banks() to ppc4xx_sdram.c
ppc4xx_sdram: Use hwaddr for memory bank size
ppc4xx_sdram: Rename local state variable for brevity
ppc4xx_sdram: Generalise bank setup
ppc4xx_sdram: Convert DDR SDRAM controller to new bank handling
ppc4xx_sdram: Add errp parameter to ppc4xx_sdram_banks()

 hw/ppc/meson.build      |   3 +-
 hw/ppc/ppc440_uc.c      | 332 ------------------
 hw/ppc/ppc4xx_devs.c    | 414 ----------------------
 hw/ppc/ppc4xx_sdram.c   | 757 ++++++++++++++++++++++++++++++++++++++++
 hw/ppc/trace-events     |   1 +
 include/hw/ppc/ppc4xx.h |  20 +-
 6 files changed, 768 insertions(+), 759 deletions(-)
 create mode 100644 hw/ppc/ppc4xx_sdram.c
Signature · 1 line
2.30.4