xfrm: start adding netlink extack support
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | xfrm: propagate extack to all netlink doit handlersnet/ | +34 | 0 replies | |
| 2/6 | xfrm: add extack support to verify_newpolicy_infonet/ | +18 | 0 replies | |
| 3/6 | xfrm: add extack to verify_policy_dirnet/ | +5 | 0 replies | |
| 4/6 | xfrm: add extack to verify_policy_typenet/ | +17 | 0 replies | |
| 5/6 | xfrm: add extack to validate_tmplnet/ | +20 | 0 replies | |
| 6/6 | xfrm: add extack to verify_sec_ctx_lennet/ | +9 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH ipsec-next 0/6] xfrm: start adding netlink extack support
XFRM states and policies are complex objects, and there are many reasons why the kernel can reject userspace's request to create one. This series makes it a bit clearer by providing extended ack messages for policy creation.
A few other operations that reuse the same helper functions are also getting partial extack support in this series. More patches will follow to complete extack support, in particular for state creation.
Note: The policy->share attribute seems to be entirely ignored in the kernel outside of checking its value in verify_newpolicy_info(). There are some (very) old comments in copy_from_user_policy and copy_to_user_policy suggesting that it should at least be copied to/from userspace. I don't know what it was intended for.
Sabrina Dubroca (6):
xfrm: propagate extack to all netlink doit handlers
xfrm: add extack support to verify_newpolicy_info
xfrm: add extack to verify_policy_dir
xfrm: add extack to verify_policy_type
xfrm: add extack to validate_tmpl
xfrm: add extack to verify_sec_ctx_len
net/xfrm/xfrm_user.c | 163 +++++++++++++++++++++++++++---------------- 1 file changed, 103 insertions(+), 60 deletions(-)
Signature · 1 line
2.37.2