Skip to content

mlxsw: Configure max LAG ID for Spectrum-4

Petr Machata netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesApplied 4/4

Patches in v1 All 4 applied

#Subject and filesSizeRepliesApplied
1/4mlxsw: cmd: Edit the comment of 'max_lag' field in CONFIG_PROFILEdrivers/net/ethernet/mellanox/mlxsw/cmd.h+3 -00 repliesApplied
2/4mlxsw: Support configuring 'max_lag' via CONFIG_PROFILEdrivers/net/ethernet/mellanox/mlxsw/core.h drivers/net/ethernet/mellanox/mlxsw/pci.c+7 -00 repliesApplied
3/4mlxsw: Add a helper function for getting maximum LAG IDdrivers/net/ethernet/mellanox/mlxsw/core.c drivers/net/ethernet/mellanox/mlxsw/core.h drivers/net/ethernet/mellanox/mlxsw/spectrum.c+36 -110 repliesApplied
4/4mlxsw: spectrum: Add a copy of 'struct mlxsw_config_profile' for Spectrum-4drivers/net/ethernet/mellanox/mlxsw/spectrum.c+28 -10 repliesApplied

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchIdo SchimmelPetr Machata
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/4] mlxsw: Configure max LAG ID for Spectrum-4

Amit Cohen writes:

In the device, LAG identifiers are stored in the port group table (PGT). During initialization, firmware reserves a certain amount of entries at the beginning of this table for LAG identifiers.

In Spectrum-4, the size of the PGT table did not increase, but the maximum number of LAG identifiers was doubled, leaving less room for others entries (e.g., flood entries) that also reside in the PGT.

Therefore, in order to avoid a regression and as long as there is no explicit requirement to support 256 LAGs, configure the firmware to allocate the same amount of LAG entries (128) as in Spectrum-{2,3}.

This can be done via the 'max_lag' field in CONFIG_PROFILE command.

Patch set overview:
Patch #1 edits the comment of the existing 'max_lag' field. Patch #2 adds support for configuring 'max_lag' field via CONFIG_PROFILE command.
Patch #3 adds an helper function to get the actual 'max_lag' in the device.
Patch #4 adjusts Spectrum-4 to configure 'max_lag' field.

Amit Cohen (4):
mlxsw: cmd: Edit the comment of 'max_lag' field in CONFIG_PROFILE
mlxsw: Support configuring 'max_lag' via CONFIG_PROFILE
mlxsw: Add a helper function for getting maximum LAG ID
mlxsw: spectrum: Add a copy of 'struct mlxsw_config_profile' for
Spectrum-4

 drivers/net/ethernet/mellanox/mlxsw/cmd.h     |  3 ++
 drivers/net/ethernet/mellanox/mlxsw/core.c    | 25 ++++++++--
 drivers/net/ethernet/mellanox/mlxsw/core.h    |  4 ++
 drivers/net/ethernet/mellanox/mlxsw/pci.c     |  5 ++
 .../net/ethernet/mellanox/mlxsw/spectrum.c    | 49 ++++++++++++++++---
 5 files changed, 74 insertions(+), 12 deletions(-)
Signature · 1 line
2.35.3