Skip to content

staging: vt6655: Improve coding style in mac.h

Philipp Hortmann linux-staging lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9staging: vt6655: Remove declaration of s_vCalculateOFDMRParameterdrivers/staging/vt6655/card.c+0 -40 replies
2/9staging: vt6655: Convert macro MACvSetBBType to functiondrivers/staging/vt6655/card.c drivers/staging/vt6655/mac.h+10 -90 replies
3/9staging: vt6655: Rename function MACvSetBBTypedrivers/staging/vt6655/card.c+4 -40 replies
4/9staging: vt6655: Rename macro MACvSelectPage0drivers/staging/vt6655/card.c drivers/staging/vt6655/channel.c drivers/staging/vt6655/device_main.c +2 more+8 -90 replies
5/9staging: vt6655: Rename macro MACvSelectPage1drivers/staging/vt6655/card.c drivers/staging/vt6655/channel.c drivers/staging/vt6655/device_main.c +2 more+8 -90 replies
6/9staging: vt6655: Replace macro MACvSetRFLE_LatchBasedrivers/staging/vt6655/baseband.c drivers/staging/vt6655/mac.h+1 -40 replies
7/9staging: vt6655: Rename function MACbIsRegBitsOffdrivers/staging/vt6655/mac.c drivers/staging/vt6655/mac.h+8 -100 replies
8/9staging: vt6655: Delete function MACbIsIntDisabledrivers/staging/vt6655/mac.c drivers/staging/vt6655/mac.h+0 -260 replies
9/9staging: vt6655: Rename function MACvSetShortRetryLimitdrivers/staging/vt6655/device_main.c drivers/staging/vt6655/mac.c drivers/staging/vt6655/mac.h+6 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] staging: vt6655: Improve coding style in mac.h

Rename function and macro names and variable names to improve CamelCase which is not accepted by checkpatch. Delete unused function declarations. Delete unused functions. Convert functions to macros and make them static when possible.

Tested with vt6655 on mini PCI Module Transferred this patch over wlan connection of vt6655

Philipp Hortmann (9):
staging: vt6655: Remove declaration of s_vCalculateOFDMRParameter
staging: vt6655: Convert macro MACvSetBBType to function
staging: vt6655: Rename function MACvSetBBType
staging: vt6655: Rename macro MACvSelectPage0
staging: vt6655: Rename macro MACvSelectPage1
staging: vt6655: Replace macro MACvSetRFLE_LatchBase
staging: vt6655: Rename function MACbIsRegBitsOff
staging: vt6655: Delete function MACbIsIntDisable
staging: vt6655: Rename function MACvSetShortRetryLimit

 drivers/staging/vt6655/baseband.c    |  2 +-
 drivers/staging/vt6655/card.c        | 22 +++++++----
 drivers/staging/vt6655/channel.c     |  4 +-
 drivers/staging/vt6655/device_main.c | 14 +++----
 drivers/staging/vt6655/mac.c         | 56 ++++++++--------------------
 drivers/staging/vt6655/mac.h         | 26 ++-----------
 6 files changed, 43 insertions(+), 81 deletions(-)
Signature · 1 line
2.37.2