Skip to content

RFC UFS Multi-Circular Queue (MCQ)

Asutosh Das linux-arm-msm linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 RFC Latest4 patches 16 repliesIn review

Changes in v3 from the cover letter

- Split the changes based on functionality
- Addressed queue configuration issues
- Faster SQE tail pointer increments
- Addressed comments from Bart and Manivannan

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ufs: core: prepare ufs for multi circular queue supportdrivers/ufs/core/ufshcd.c+53 -467 replies
2/4ufs: core: mcq: Adds Multi-Circular Queue supportdrivers/ufs/core/Makefile drivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h +4 more+1012 -417 replies
3/4ufs: core: Add Event Specific Interrupt configuration vendor specific opsdrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c +1 more+33 -00 replies
4/4ufs: host: qcom: Add MCQ supportdrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/host/ufs-qcom.c +2 more+150 -22 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [RFC PATCH v3 0/4] UFS Multi-Circular Queue (MCQ)

UFS Multi-Circular Queue (MCQ) has been added in UFSHCI v4.0 to improve storage performance. This patch series is a RFC implementation of this.

This is the initial driver implementation and it has been verified by booting on an emulation platform. During testing, all low power modes were disabled and it was in HS-G1 mode.

Please take a look and let us know your thoughts.

v2 -> v3:
- Split the changes based on functionality
- Addressed queue configuration issues
- Faster SQE tail pointer increments
- Addressed comments from Bart and Manivannan

v1 -> v2:
- Enabled host_tagset
- Added queue num configuration support
- Added one more vops to allow vendor provide the wanted MAC
- Determine nutrs and can_queue by considering both MAC, bqueuedepth and EXT_IID support
- Postponed MCQ initialization and scsi_add_host() to async probe
- Used (EXT_IID, Task Tag) tuple to support up to 4096 tasks (theoretically)

Asutosh Das (2):
ufs: core: prepare ufs for multi circular queue support
ufs: core: mcq: Adds Multi-Circular Queue support

Can Guo (2):
ufs: core: Add Event Specific Interrupt configuration vendor specific
ops
ufs: host: qcom: Add MCQ support

 drivers/ufs/core/Makefile      |   2 +-
 drivers/ufs/core/ufs-mcq.c     | 474 +++++++++++++++++++++++++++++++++++++++++
 drivers/ufs/core/ufshcd-priv.h | 102 +++++++++
 drivers/ufs/core/ufshcd.c      | 370 +++++++++++++++++++++++++-------
 drivers/ufs/host/ufs-qcom.c    | 134 ++++++++++++
 drivers/ufs/host/ufs-qcom.h    |  13 ++
 include/ufs/ufs.h              |   6 +
 include/ufs/ufshcd.h           | 137 ++++++++++++
 include/ufs/ufshci.h           |  79 +++++++
 9 files changed, 1238 insertions(+), 79 deletions(-)
 create mode 100644 drivers/ufs/core/ufs-mcq.c
Signature · 1 line
2.7.4