btrfs: optimize the argument list for submit_extent_page()
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 2 repliesIn review
- v12 patches 2 repliesSuperseded
Changes in v2 from the cover letter
- Add a patch to remove stale argument from the comments of submit_extent_page()
- Update the comment of submit_extent_page() to reflect the new arugment list
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | btrfs: update the comment for submit_extent_page()fs/ | +5 | 1 reply | |
| 2/3 | btrfs: switch the page and disk_bytenr argument position for submit_extent_page()fs/ | +9 | 0 replies | |
| 3/3 | btrfs: move end_io_func argument to btrfs_bio_ctrl structurefs/ | +23 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Anand Jain |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/3] btrfs: optimize the argument list for submit_extent_page()
[Changelog]
v2:
- Add a patch to remove stale argument from the comments of submit_extent_page()
- Update the comment of submit_extent_page() to reflect the new arugment list
The argument list of submit_extent_page() is already a little long.
Although we have things like page, pg_len, pg_off which can not be saved anyway, we can still improve the situation by:
- Update the stale comment of submit_extent_page() Done by the first patch.
- Make sure @page, @pg_len, @pg_off are always batched together Just like bio_add_page().
This is done by the second page, just switching the position between @page and @disk_bytenr.
- Move @end_io_func arugment into btrfs_bio_ctrl structure.
Qu Wenruo (3):
btrfs: update the comment for submit_extent_page()
btrfs: switch the page and disk_bytenr argument position for
submit_extent_page()
btrfs: move end_io_func argument to btrfs_bio_ctrl structure
fs/btrfs/extent_io.c | 66 +++++++++++++++++++++++++------------------- 1 file changed, 37 insertions(+), 29 deletions(-)
Signature · 1 line
2.37.3