Skip to content

Check enumeration before MSR save/restore

Pawan Gupta linux-pm lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 5 repliesIn review
  2. v22 patches 0 repliesSuperseded
  3. v13 patches 21 repliesSuperseded

Changes in v3 from the cover letter

- Rebased to latest upstream.
- Made MSR_AMD64_DE_CFG restore depend on X86_FEATURE_LFENCE_RDTSC.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2x86/tsx: Add feature bit for TSX control MSR supportarch/x86/include/asm/cpufeatures.h arch/x86/kernel/cpu/tsx.c+16 -151 reply
2/2x86/pm: Add enumeration check before spec MSRs save/restore setuparch/x86/power/cpu.c+17 -84 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRafael J. WysockiDave Hansen
1/2R-b
2/2A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Check enumeration before MSR save/restore

v3:
- Rebased to latest upstream.
- Made MSR_AMD64_DE_CFG restore depend on X86_FEATURE_LFENCE_RDTSC.

v2: https://lore.kernel.org/lkml/[email protected]/
- Dropped patch for X86_FEATURE_AMD64_LS_CFG, using X86_FEATURE_AMD64_LS_CFG_SSBD instead.
- Commit message updated.

v1: https://lore.kernel.org/lkml/[email protected]/

Hi,

This patchset is to fix the "unchecked MSR access error" [1] during S3 resume. Patch 1/3 adds a feature bit for MSR_IA32_TSX_CTRL.

Patch 2/3 adds a feature bit for MSR_AMD64_LS_CFG.

Patch 3/3 adds check for feature bit before adding any speculation control MSR to the list of MSRs to save/restore.

[1] https://lore.kernel.org/lkml/[email protected]/

Thanks,
Pawan

Pawan Gupta (2):
x86/tsx: Add feature bit for TSX control MSR support x86/pm: Add enumeration check before spec MSRs save/restore setup

 arch/x86/include/asm/cpufeatures.h |  1 +
 arch/x86/kernel/cpu/tsx.c          | 30 +++++++++++++++---------------
 arch/x86/power/cpu.c               | 25 +++++++++++++++++--------
 3 files changed, 33 insertions(+), 23 deletions(-)
Signature · 1 line
2.37.3

Read the cover letter in its thread