Skip to content

Reduce SMBDirect RDMA SGE counts and sizes

Tom Talpey linux-cifs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 16 repliesIn review
  2. v1 RFC6 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6Decrease the number of SMB3 smbdirect client SGEsfs/cifs/smbdirect.c fs/cifs/smbdirect.h+21 -190 replies
2/6Decrease the number of SMB3 smbdirect server SGEsfs/ksmbd/transport_rdma.c+1 -11 reply
3/6Reduce client smbdirect max receive segment sizefs/cifs/smbdirect.c+1 -10 replies
4/6Reduce server smbdirect max send/receive segment sizesfs/ksmbd/transport_rdma.c+2 -28 replies
5/6Handle variable number of SGEs in client smbdirect send.fs/cifs/smbdirect.c+77 -1080 replies
6/6Fix formatting of client smbdirect RDMA loggingfs/cifs/smbdirect.c+7 -70 replies

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNamjae JeonPaulo Alcantara (SUSE)
SeriesA-b
1/6
2/6A-b
3/6
4/6A-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] Reduce SMBDirect RDMA SGE counts and sizes

Allocate fewer SGEs and standard packet sizes in both kernel SMBDirect implementations.

The current maximum values (16 SGEs and 8192 bytes) cause failures on the SoftiWARP provider, and are suboptimal on others. Reduce these to 6 and 1364. Additionally, recode smbd_send() to work with as few as 2 SGEs, and for debug sanity, reformat client-side logging to more clearly show addresses, lengths and flags in the appropriate base.

Tested over SoftiWARP and SoftRoCE with shell, Connectathon basic and general.

v2: correct an uninitialized value issue found by Coverity

Tom Talpey (6):
Decrease the number of SMB3 smbdirect client SGEs Decrease the number of SMB3 smbdirect server SGEs Reduce client smbdirect max receive segment size Reduce server smbdirect max send/receive segment sizes Handle variable number of SGEs in client smbdirect send. Fix formatting of client smbdirect RDMA logging

 fs/cifs/smbdirect.c       | 227 ++++++++++++++++----------------------
 fs/cifs/smbdirect.h       |  14 ++-
 fs/ksmbd/transport_rdma.c |   6 +-
 3 files changed, 109 insertions(+), 138 deletions(-)
Signature · 1 line
2.34.1