Skip to content

cifs: don't send uninitialized memory to sock_{send,recv}msg()

Stefan Metzmacher linux-cifs stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2cifs: don't send down the destination address to sendmsg for a SOCK_STREAMfs/cifs/transport.c+2 -20 replies
2/2cifs: always initialize struct msghdr smb_msg completelyfs/cifs/connect.c fs/cifs/transport.c+4 -130 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPaulo Alcantara (SUSE)
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] cifs: don't send uninitialized memory to sock_{send,recv}msg()

Passing just half initialized struct msghdr variables down to sock_{send,recv}msg() means we're waiting for a disater to happen...

I added the removal of passing the destination address to tcp as a separate patch in order to explain it separately.

Stefan Metzmacher (2):
cifs: don't send down the destination address to sendmsg for a
SOCK_STREAM
cifs: always initialize struct msghdr smb_msg completely

 fs/cifs/connect.c   | 11 +++--------
 fs/cifs/transport.c |  6 +-----
 2 files changed, 4 insertions(+), 13 deletions(-)
Signature · 1 line
2.34.1