Skip to content

RFC staging: vt6655: Implement allocation failure handling

Nam Cao linux-staging lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest4 patches 1 replyIn review
  2. v1 RFC5 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- squash 3 commits that were doing a single thing
- add new commit which removes a redundant assignment
- take device_init_rx_desc() out of unnecessary else condition.
- remove return statement at the end of void function
- add a missing rd = rd->next statement in device_rx_srv(): because we already drop the current buffer, we should move on to the next buffer in the ring where new data will be written to.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging: vt6655: remove redundant if conditiondrivers/staging/vt6655/device_main.c+6 -60 replies
2/4staging: vt6655: change vnt_receive_frame return type to voiddrivers/staging/vt6655/dpc.c drivers/staging/vt6655/dpc.h+4 -60 replies
3/4staging: vt6655: remove redundant assignmentdrivers/staging/vt6655/device_main.c+0 -10 replies
4/4staging: vt6655: implement allocation failure handlingdrivers/staging/vt6655/device_main.c+21 -120 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchPhilipp Hortmann
SeriesT-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [RFC PATCH v2 0/4] staging: vt6655: Implement allocation failure handling

This driver does not handle allocation failure when receiving data very well. This patchset implements better handling in the case of allocation failure.

Also do some necessary clean-up to implement this.

v2:
- squash 3 commits that were doing a single thing
- add new commit which removes a redundant assignment
- take device_init_rx_desc() out of unnecessary else condition.
- remove return statement at the end of void function
- add a missing rd = rd->next statement in device_rx_srv(): because we already drop the current buffer, we should move on to the next buffer in the ring where new data will be written to.

Nam Cao (4):
staging: vt6655: remove redundant if condition
staging: vt6655: change vnt_receive_frame return type to void
staging: vt6655: remove redundant assignment
staging: vt6655: implement allocation failure handling

 drivers/staging/vt6655/device_main.c | 40 +++++++++++++++++-----------
 drivers/staging/vt6655/dpc.c         |  8 +++---
 drivers/staging/vt6655/dpc.h         |  2 +-
 3 files changed, 28 insertions(+), 22 deletions(-)
Signature · 1 line
2.25.1