Skip to content

crypto: inside-secure: Add Support for MaxLinear Platform

Peter Harliman Liem linux-crypto 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v10 of 3 patches 0 repliesSuperseded

Changes in v2 from the cover letter

Revert directory change for generic case.
Add missing driver data change in pci_device_id.
Rename data struct to safexcel_priv_data.
Rework endianness selection code casting, to fix warning caught by kernel test robot. Rename mxl version string to eip197 'c'.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3crypto: inside-secure - Expand soc data structuredrivers/crypto/inside-secure/safexcel.c drivers/crypto/inside-secure/safexcel.h+35 -150 replies
2/3crypto: inside-secure - Add fw_little_endian optiondrivers/crypto/inside-secure/safexcel.c drivers/crypto/inside-secure/safexcel.h+11 -40 replies
3/3crypto: inside-secure - Add MaxLinear platformdrivers/crypto/inside-secure/safexcel.c drivers/crypto/inside-secure/safexcel.h+13 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] crypto: inside-secure: Add Support for MaxLinear Platform

Hi,

I have been utilizing inside-secure driver on MaxLinear SoC platform (which has eip197 hardware inside).

One issue I found is that I needed to flip the endianness in eip197_write_firmware() function, which for reason I am not aware is using big-endian.
The firmware that I have is clearly using little-endian, and unfortunately I do not have access to Marvell platform to do more investigation or comparison there.
I have also tried to look for clues in Inside-Secure's hardware/firmware documentation, without success.

Thus, assuming each vendor may use different endian format, on these patch set I add support for little-endian firmware (default remains big-endian). MaxLinear platform can then utilize the option, which is implemented as soc data.

An alternative to this would be implementing the option as a new device-tree property, but for now I assume we do not need that since each platform endianness should be fixed, and will not vary per board/hardware.

Please help review.

Thanks!

v2:
Revert directory change for generic case.
Add missing driver data change in pci_device_id.
Rename data struct to safexcel_priv_data.
Rework endianness selection code casting, to fix warning caught by kernel test robot. Rename mxl version string to eip197 'c'.

Peter Harliman Liem (3):
crypto: inside-secure - Expand soc data structure
crypto: inside-secure - Add fw_little_endian option
crypto: inside-secure - Add MaxLinear platform

 drivers/crypto/inside-secure/safexcel.c | 69 ++++++++++++++++++-------
 drivers/crypto/inside-secure/safexcel.h | 10 +++-
 2 files changed, 59 insertions(+), 20 deletions(-)
Signature · 1 line
2.17.1