Skip to content

Add Multi Circular Queue Support

Asutosh Das linux-arm-kernel linux-arm-msm linux-mediatek linux-scsi lkml 13 versions – Applied

Status from this message: Applied to 6.3/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v13 Latest15 patches 2 repliesApplied
  2. v1215 patches 1 replySuperseded
  3. v1116 patches 11 repliesSuperseded
Earlier versions · 10
VersionPostedPatchesRepliesStatus
v1016 patches0 repliesSuperseded
v916 patches3 repliesSuperseded
v816 patches2 repliesSuperseded
v716 patches7 repliesSuperseded
v616 patches10 repliesSuperseded
v516 patches28 repliesSuperseded
v416 patches9 repliesSuperseded
v317 patches30 repliesSuperseded
v217 patches18 repliesSuperseded
v116 patches23 repliesSuperseded

Changes in v13 from the cover letter

- Rebased on top of latest Martin's tree and fixed conflicts
- Fixed merged conflicts due to (3d2f12b Merge patch series "ufs: qcom: Add HS-G4 support") in 0003-ufs-core-Defer-adding-host-to-scsi-if-mcq-is-support.patch to support the reinitialization needed on Qualcomm platforms for HS-G4.

Patches in v13 Applied

#Subject and filesSizeRepliesApplied
1/15ufs: core: Probe for ext_iid supportdrivers/ufs/core/ufshcd.c include/ufs/ufs.h include/ufs/ufshcd.h +1 more+48 -00 replies
2/15ufs: core: Introduce Multi-circular queue capabilitydrivers/ufs/core/ufshcd.c include/ufs/ufshcd.h+28 -00 replies
3/15ufs: core: Defer adding host to scsi if mcq is supporteddrivers/ufs/core/ufshcd.c include/ufs/ufshcd.h+21 -40 replies
4/15ufs: core: mcq: Add support to allocate multiple queuesdrivers/ufs/core/Makefile drivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h +2 more+142 -10 replies
5/15ufs: core: mcq: Configure resource regionsdrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/host/ufs-qcom.c +1 more+142 -00 replies
6/15ufs: core: mcq: Calculate queue depthdrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c +5 more+73 -10 replies
7/15ufs: core: mcq: Allocate memory for mcq modedrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c +2 more+145 -50 replies
8/15ufs: core: mcq: Configure operation and runtime interfacedrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c +3 more+247 -00 replies
9/15ufs: core: mcq: Use shared tags for MCQ modedrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd.c+18 -120 replies
10/15ufs: core: Prepare ufshcd_send_command for mcqdrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c +1 more+43 -110 replies
11/15ufs: core: mcq: Find hardware queue to queue requestdrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c+25 -00 replies
12/15ufs: core: Prepare for completion in mcqdrivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c+51 -310 replies
13/15ufs: mcq: Add completion support of a cqedrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c +4 more+169 -00 replies
14/15ufs: core: mcq: Add completion support in polldrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c +1 more+24 -00 replies
15/15ufs: core: mcq: Enable Multi Circular Queuedrivers/ufs/core/ufshcd.c+6 -00 replies

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchBart Van AsscheManivannan SadhasivamAvri AltmanStanley Chu
1/15R-b R-b R-b R-b
2/15R-b R-b R-b
3/15R-b R-b
4/15R-b R-b
5/15R-b R-b R-b
6/15R-b R-b R-b
7/15R-b R-b
8/15R-b R-b
9/15R-b R-b R-b
10/15R-b R-b R-b
11/15R-b R-b
12/15R-b R-b R-b
13/15R-b R-b R-b
14/15R-b R-b R-b
15/15R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v13 thread

Cover letter [PATCH v13 00/15] Add Multi Circular Queue Support

Hi Martin,

This patch series is an implementation of UFS Multi-Circular Queue. Please consider this series for next merge window.
This implementation has been verified on a Qualcomm & MediaTek platform.

Thanks,
Asutosh

UFS Multi-Circular Queue (MCQ) has been added in UFSHCI v4.0 to improve storage performance. The implementation uses the shared tagging mechanism so that tags are shared among the hardware queues. The number of hardware queues is configurable. This series doesn't include the ESI implementation for completion handling.

Please take a look and let us know your thoughts.

v12 -> v13:
- Rebased on top of latest Martin's tree and fixed conflicts
- Fixed merged conflicts due to (3d2f12b Merge patch series "ufs: qcom: Add HS-G4 support") in 0003-ufs-core-Defer-adding-host-to-scsi-if-mcq-is-support.patch to support the reinitialization needed on Qualcomm platforms for HS-G4.

v11 -> v12:
- Dropped 0001-ufs-core-Optimize-duplicate-code-to-read-extended-fe.patch.
Arthur's change series
(https://lore.kernel.org/r/[email protected]) makes this change unnecessary.
- Pass hwq as a parameter to ufshcd_send_command() in ufshcd_advanced_rpmb_req_handler()
- Added Stanley Chu's Reviewed-by tags

v10 -> v11:
- Added Stanley Chu's Reviewed-by tags

v9 -> v10:
- Fix few checkpatch warnings
- Use div_u64() instead of direct division in ufshcd_mcq_get_tag() to fix a LKP warning

v8 -> v9:
- Added missing Reviewed-by tags.

v7 -> v8:
- Addressed Eddie's comments

v6 -> v7:
- Added missing Reviewed-by tags.

v5 -> v6:
- Addressed Mani's comments
- Addressed Bart's comments

v4 -> v5:
- Fixed failure to fallback to SDB during initialization
- Fixed failure when rpm-lvl=5 in the ufshcd_host_reset_and_restore() path
- Improved ufshcd_mcq_config_nr_queues() to handle different configurations
- Addressed Bart's comments
- Verified read/write using FIO, clock gating, runtime-pm[lvl=3, lvl=5]

v3 -> v4:
- Added a kernel module parameter to disable MCQ mode
- Added Bart's reviewed-by tag for some patches
- Addressed Bart's comments

v2 -> v3:
- Split ufshcd_config_mcq() into ufshcd_alloc_mcq() and ufshcd_config_mcq()
- Use devm_kzalloc() in ufshcd_mcq_init()
- Free memory and resource allocation on error paths
- Corrected typos in code comments

v1 -> v2:
- Added a non MCQ related change to use a function to extrace ufs extended feature
- Addressed Mani's comments
- Addressed Bart's comments

v1:
- Split the changes
- Addressed Bart's comments
- Addressed Bean's comments

* RFC versions:
v2 -> v3:
- Split the changes based on functionality
- Addressed queue configuration issues
- Faster SQE tail pointer increments
- Addressed comments from Bart and Manivannan

v1 -> v2:
- Enabled host_tagset
- Added queue num configuration support
- Added one more vops to allow vendor provide the wanted MAC
- Determine nutrs and can_queue by considering both MAC, bqueuedepth and EXT_IID support
- Postponed MCQ initialization and scsi_add_host() to async probe
- Used (EXT_IID, Task Tag) tuple to support up to 4096 tasks (theoretically)

Asutosh Das (15):
ufs: core: Probe for ext_iid support
ufs: core: Introduce Multi-circular queue capability
ufs: core: Defer adding host to scsi if mcq is supported
ufs: core: mcq: Add support to allocate multiple queues
ufs: core: mcq: Configure resource regions
ufs: core: mcq: Calculate queue depth
ufs: core: mcq: Allocate memory for mcq mode
ufs: core: mcq: Configure operation and runtime interface
ufs: core: mcq: Use shared tags for MCQ mode
ufs: core: Prepare ufshcd_send_command for mcq
ufs: core: mcq: Find hardware queue to queue request
ufs: core: Prepare for completion in mcq
ufs: mcq: Add completion support of a cqe
ufs: core: mcq: Add completion support in poll
ufs: core: mcq: Enable Multi Circular Queue

 drivers/ufs/core/Makefile      |   2 +-
 drivers/ufs/core/ufs-mcq.c     | 415 +++++++++++++++++++++++++++++++++++++++++
 drivers/ufs/core/ufshcd-priv.h |  92 ++++++++-
 drivers/ufs/core/ufshcd.c      | 377 +++++++++++++++++++++++++++++++------
 drivers/ufs/host/ufs-qcom.c    | 146 +++++++++++++++
 drivers/ufs/host/ufs-qcom.h    |   5 +
 include/ufs/ufs.h              |   7 +
 include/ufs/ufshcd.h           | 129 +++++++++++++
 include/ufs/ufshci.h           |  64 +++++++
 9 files changed, 1177 insertions(+), 60 deletions(-)
 create mode 100644 drivers/ufs/core/ufs-mcq.c
Signature · 1 line
2.7.4