Skip to content

btrfs-progs: enhance error handling for metadata writeback

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs-progs: remove unused function extent_io_tree_init_cache_max()kernel-shared/extent_io.c kernel-shared/extent_io.h+0 -90 replies
2/3btrfs-progs: remove duplicated leakde extent buffer reporstkernel-shared/extent_io.c+5 -00 replies
3/3btrfs-progs: properly handle write error when writing back tree blockskernel-shared/extent_io.c kernel-shared/transaction.c+32 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] btrfs-progs: enhance error handling for metadata writeback

Christoph Anton Mitterer reported a crash if we try to call "btrfs check --clear-space-cache v2" on a block device which is set read-only by "blockdev --setro".

For such blockdevice, open() with O_RDWR won't report error immediately, but only return error when we write to do any writes.

So what we can do is to enhance the error handling of metadata writeback during transaction commit.

The first 2 patches are cleanups/fixes I exposed during the development. The last one is the main disk for the fix.

Qu Wenruo (3):
btrfs-progs: remove unused function extent_io_tree_init_cache_max()
btrfs-progs: remove duplicated leakde extent buffer reporst
btrfs-progs: properly handle write error when writing back tree blocks

 kernel-shared/extent_io.c   | 14 ++++++--------
 kernel-shared/extent_io.h   |  2 --
 kernel-shared/transaction.c | 33 +++++++++++++++++++++++++++++++--
 3 files changed, 37 insertions(+), 12 deletions(-)
Signature · 1 line
2.37.3