Skip to content

Ensure that file descriptors will be closed on exit

Mauro Carvalho Chehab igt-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest76 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/76lib: Introduce typed cleanupslib/igt_core.c lib/igt_core.h lib/igt_types.c +5 more+230 -03 replies
2/76i915/gem_basic: Close device before exittests/i915/gem_basic.c+5 -30 replies
3/76i915/gem_flink_basic: Close device before exittests/i915/gem_flink_basic.c+8 -30 replies
4/76i915/gem_linear_blits: Close device before exittests/i915/gem_linear_blits.c+2 -10 replies
5/76i915/gem_blits: Close device before exittests/i915/gem_blits.c+1 -00 replies
6/76i915/gem_close: Close device before exittests/i915/gem_close.c+2 -10 replies
7/76i915/gem_create: Close device before exittests/i915/gem_create.c+2 -10 replies
8/76i915/gem_ctx_engines: Close device before exittests/i915/gem_ctx_engines.c+2 -10 replies
9/76i915/gem_ctx_shared: Close device before exittests/i915/gem_ctx_shared.c+2 -10 replies
10/76i915/gem_exec_alignment: Close device before exittests/i915/gem_exec_alignment.c+2 -10 replies
11/76i915/gem_render_copy: Close device before exittests/i915/gem_render_copy.c+1 -00 replies
12/76i915/gem_render_copy_redux: Close device before exittests/i915/gem_render_copy_redux.c+4 -00 replies
13/76i915/gem_media_fill: Close device before exittests/i915/gem_media_fill.c+1 -00 replies
14/76i915/gem_userptr_blits: Close device before exittests/i915/gem_userptr_blits.c+3 -10 replies
15/76i915/gem_workarounds: Close device before exittests/i915/gem_workarounds.c+2 -10 replies
16/76i915/gem_unref_active_buffers: Close device before exittests/i915/gem_unref_active_buffers.c+1 -00 replies
17/76i915/gem_exec_endless: Close device before exittests/i915/gem_exec_endless.c+2 -11 reply
18/76i915/gem_request_retire: Close device before exittests/i915/gem_request_retire.c+3 -20 replies
19/76i915/gem_unfence_active_buffers: Close device before exittests/i915/gem_unfence_active_buffers.c+1 -00 replies
20/76i915/i915_pciid: Close device before exittests/i915/i915_pciid.c+2 -00 replies
21/76kms_cursor_legacy: Close device before exittests/kms_cursor_legacy.c+1 -00 replies
22/76kms_flip: Close device before exittests/kms_flip.c+3 -00 replies
23/76kms_pipe_crc_basic: Close device before exittests/kms_pipe_crc_basic.c+1 -00 replies
24/76kms_psr: Close device before exittests/i915/kms_psr.c+1 -00 replies
25/76kms_flip: Close device before exittests/i915/kms_busy.c+1 -00 replies
26/76kms_force_connector_basic: Close device before exittests/kms_force_connector_basic.c+6 -10 replies
27/76dumb_buffer: Close device before exittests/dumb_buffer.c+4 -00 replies
28/76kms_atomic: Close device before exittests/kms_atomic.c+1 -00 replies
29/76kms_atomic_interruptible: Close device before exittests/kms_atomic_interruptible.c+1 -00 replies
30/76kms_atomic_transition: Close device before exittests/kms_atomic_transition.c+1 -00 replies
31/76i915/kms_big_fb: Close device before exittests/i915/kms_big_fb.c+1 -00 replies
32/76i915/kms_ccs: Close device before exittests/i915/kms_ccs.c+3 -10 replies
33/76kms_color: Close device before exittests/kms_color.c+1 -00 replies
34/76kms_cursor_crc: Close device before exittests/kms_cursor_crc.c+1 -00 replies
35/76i915/kms_big_joiner: Close device before exittests/i915/kms_big_joiner.c+1 -00 replies
36/76i915/kms_cdclk: Close device before exittests/i915/kms_cdclk.c+1 -00 replies
37/76i915/kms_fence_pin_leak: Close device before exittests/i915/kms_fence_pin_leak.c+1 -00 replies
38/76i915/kms_flip_scaled_crc: Close device before exittests/i915/kms_flip_scaled_crc.c+1 -00 replies
39/76i915/kms_flip_tiling: Close device before exittests/i915/kms_flip_tiling.c+1 -00 replies
40/76i915/kms_mmap_write_crc: Close device before exittests/i915/kms_mmap_write_crc.c+1 -00 replies
41/76i915/kms_pipe_b_c_ivb: Close device before exittests/i915/kms_pipe_b_c_ivb.c+1 -00 replies
42/76i915/kms_psr2_sf: Close device before exittests/i915/kms_psr2_sf.c+1 -00 replies
43/76i915/kms_psr2_su: Close device before exittests/i915/kms_psr2_su.c+1 -00 replies
44/76i915/kms_pwrite_crc: Close device before exittests/i915/kms_pwrite_crc.c+1 -00 replies
45/76kms_flip_event_leak: Close device before exittests/kms_flip_event_leak.c+1 -00 replies
46/76kms_hdr: Close device before exittests/kms_hdr.c+1 -00 replies
47/76kms_invalid_mode: Close device before exittests/kms_invalid_mode.c+1 -00 replies
48/76kms_panel_fitting: Close device before exittests/kms_panel_fitting.c+3 -10 replies
49/76kms_plane: Close device before exittests/kms_plane.c+1 -00 replies
50/76kms_plane_alpha_blend: Close device before exittests/kms_plane_alpha_blend.c+1 -00 replies
51/76kms_plane_cursor: Close device before exittests/kms_plane_cursor.c+1 -00 replies
52/76kms_plane_multiple: Close device before exittests/kms_plane_multiple.c+3 -10 replies
53/76kms_plane_scaling: Close device before exittests/kms_plane_scaling.c+3 -10 replies
54/76kms_properties: Close device before exittests/kms_properties.c+1 -00 replies
55/76kms_rotation_crc: Close device before exittests/kms_rotation_crc.c+1 -00 replies
56/76kms_sequence: Close device before exittests/kms_sequence.c+4 -00 replies
57/76kms_universal_plane: Close device before exittests/kms_universal_plane.c+1 -00 replies
58/76kms_vblank: Close device before exittests/kms_vblank.c+4 -00 replies
59/76syncobj_wait: Close device before exittests/syncobj_wait.c+4 -00 replies
60/76syncobj_basic: Close device before exittests/syncobj_basic.c+4 -00 replies
61/76syncobj_timeline: Close device before exittests/syncobj_timeline.c+4 -00 replies
62/76drm_import_export: Close device before exittests/drm_import_export.c+5 -00 replies
63/76kms_dp_aux_dev: Close device before exittests/kms_dp_aux_dev.c+1 -00 replies
64/76kms_hdmi_inject: Close device before exittests/kms_hdmi_inject.c+1 -00 replies
65/76kms_3d: Close device before exittests/kms_3d.c+1 -00 replies
66/76kms_scaling_modes: Close device before exittests/kms_scaling_modes.c+3 -10 replies
67/76kms_dither: Close device before exittests/kms_dither.c+1 -00 replies
68/76drm_read: Close device before exittests/drm_read.c+3 -10 replies
69/76kms_cursor_edge_walk: Close device before exittests/kms_cursor_edge_walk.c+3 -10 replies
70/76kms_plane_lowres: Close device before exittests/kms_plane_lowres.c+3 -10 replies
71/76kms_content_protection: Close device before exittests/kms_content_protection.c+1 -00 replies
72/76feature_discovery: Close device before exittests/feature_discovery.c+3 -20 replies
73/76i915/i915_pm_dc: Close device before exittests/i915/i915_pm_dc.c+1 -00 replies
74/76core_auth: Close(master) before exittests/core_auth.c+5 -30 replies
75/76i915/gem_exec_balancer: Close device before exittests/i915/gem_exec_balancer.c+2 -10 replies
76/76i915/gem_ctx_isolation: Close device before exittests/i915/gem_ctx_isolation.c+2 -10 replies

Reviews trailers per patch

69 of 76 patches have a Reviewed-by or Acked-by.

PatchAndrzej HajdaMichael J. RuhlNirmoy Das
1/76A-b
2/76R-b
3/76R-b
4/76R-b
5/76A-b
6/76A-b
7/76A-b
8/76A-b
9/76A-b
10/76A-b
11/76A-b
12/76A-b
13/76A-b
14/76A-b
15/76
16/76
17/76
18/76R-b
19/76R-b
20/76A-b
21/76R-b
22/76R-b
23/76R-b
24/76R-b
25/76R-b
26/76R-b
27/76A-b
28/76A-b
29/76A-b
30/76A-b
31/76A-b
32/76A-b
33/76A-b
34/76A-b
35/76A-b
36/76A-b
37/76A-b
38/76A-b
39/76A-b
40/76A-b
41/76A-b
42/76A-b
43/76A-b
44/76A-b
45/76A-b
46/76A-b
47/76A-b
48/76A-b
49/76A-b
50/76A-b
51/76A-b
52/76A-b
53/76A-b
54/76A-b
55/76A-b
56/76A-b
57/76A-b
58/76A-b
59/76A-b
60/76A-b
61/76A-b
62/76A-b
63/76R-b
64/76
65/76
66/76
67/76
68/76R-b
69/76R-b
70/76R-b
71/76R-b
72/76R-b
73/76R-b
74/76R-b
75/76R-b
76/76A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [igt-dev] [PATCH 00/76] Ensure that file descriptors will be closed on exit

From: Mauro Carvalho Chehab <[email protected]>

GCC is usually smart enough to close devices on exit, but that doesn't work with the logic inside igt_skip(), as it uses longjmp, causing the code to go out of scope. Such scoped variables must be tracked in an outer scope to the skipping subtest.

Change the logic on IGT tests in order to avoid keeping device opened at the end of the test.

Chris Wilson (76):
lib: Introduce typed cleanups
i915/gem_basic: Close device before exit i915/gem_flink_basic: Close device before exit i915/gem_linear_blits: Close device before exit i915/gem_blits: Close device before exit i915/gem_close: Close device before exit i915/gem_create: Close device before exit i915/gem_ctx_engines: Close device before exit i915/gem_ctx_shared: Close device before exit i915/gem_exec_alignment: Close device before exit i915/gem_render_copy: Close device before exit i915/gem_render_copy_redux: Close device before exit i915/gem_media_fill: Close device before exit i915/gem_userptr_blits: Close device before exit i915/gem_workarounds: Close device before exit i915/gem_unref_active_buffers: Close device before exit i915/gem_exec_endless: Close device before exit i915/gem_request_retire: Close device before exit i915/gem_unfence_active_buffers: Close device before exit i915/i915_pciid: Close device before exit
kms_cursor_legacy: Close device before exit
kms_flip: Close device before exit
kms_pipe_crc_basic: Close device before exit
kms_psr: Close device before exit
kms_flip: Close device before exit
kms_force_connector_basic: Close device before exit
dumb_buffer: Close device before exit
kms_atomic: Close device before exit
kms_atomic_interruptible: Close device before exit
kms_atomic_transition: Close device before exit i915/kms_big_fb: Close device before exit i915/kms_ccs: Close device before exit
kms_color: Close device before exit
kms_cursor_crc: Close device before exit i915/kms_big_joiner: Close device before exit i915/kms_cdclk: Close device before exit i915/kms_fence_pin_leak: Close device before exit i915/kms_flip_scaled_crc: Close device before exit i915/kms_flip_tiling: Close device before exit i915/kms_mmap_write_crc: Close device before exit i915/kms_pipe_b_c_ivb: Close device before exit i915/kms_psr2_sf: Close device before exit i915/kms_psr2_su: Close device before exit i915/kms_pwrite_crc: Close device before exit
kms_flip_event_leak: Close device before exit
kms_hdr: Close device before exit
kms_invalid_mode: Close device before exit
kms_panel_fitting: Close device before exit
kms_plane: Close device before exit
kms_plane_alpha_blend: Close device before exit
kms_plane_cursor: Close device before exit
kms_plane_multiple: Close device before exit
kms_plane_scaling: Close device before exit
kms_properties: Close device before exit
kms_rotation_crc: Close device before exit
kms_sequence: Close device before exit
kms_universal_plane: Close device before exit
kms_vblank: Close device before exit
syncobj_wait: Close device before exit
syncobj_basic: Close device before exit
syncobj_timeline: Close device before exit
drm_import_export: Close device before exit
kms_dp_aux_dev: Close device before exit
kms_hdmi_inject: Close device before exit
kms_3d: Close device before exit
kms_scaling_modes: Close device before exit
kms_dither: Close device before exit
drm_read: Close device before exit
kms_cursor_edge_walk: Close device before exit
kms_plane_lowres: Close device before exit
kms_content_protection: Close device before exit
feature_discovery: Close device before exit i915/i915_pm_dc: Close device before exit
core_auth: Close(master) before exit i915/gem_exec_balancer: Close device before exit i915/gem_ctx_isolation: Close device before exit

 lib/igt_core.c                          |   6 ++
 lib/igt_core.h                          |   2 +
 lib/igt_types.c                         |  17 +++
 lib/igt_types.h                         |  47 ++++++++
 lib/meson.build                         |   1 +
 lib/tests/bad_subtest_type.c            |  19 ++++
 lib/tests/igt_types.c                   | 136 ++++++++++++++++++++++++
 lib/tests/meson.build                   |   2 +
 tests/core_auth.c                       |   8 +-
 tests/drm_import_export.c               |   5 +
 tests/drm_read.c                        |   4 +-
 tests/dumb_buffer.c                     |   4 +
 tests/feature_discovery.c               |   5 +-
 tests/i915/gem_basic.c                  |   8 +-
 tests/i915/gem_blits.c                  |   1 +
 tests/i915/gem_close.c                  |   3 +-
 tests/i915/gem_create.c                 |   3 +-
 tests/i915/gem_ctx_engines.c            |   3 +-
 tests/i915/gem_ctx_isolation.c          |   3 +-
 tests/i915/gem_ctx_shared.c             |   3 +-
 tests/i915/gem_exec_alignment.c         |   3 +-
 tests/i915/gem_exec_balancer.c          |   3 +-
 tests/i915/gem_exec_endless.c           |   3 +-
 tests/i915/gem_flink_basic.c            |  11 +-
 tests/i915/gem_linear_blits.c           |   3 +-
 tests/i915/gem_media_fill.c             |   1 +
 tests/i915/gem_render_copy.c            |   1 +
 tests/i915/gem_render_copy_redux.c      |   4 +
 tests/i915/gem_request_retire.c         |   5 +-
 tests/i915/gem_unfence_active_buffers.c |   1 +
 tests/i915/gem_unref_active_buffers.c   |   1 +
 tests/i915/gem_userptr_blits.c          |   4 +-
 tests/i915/gem_workarounds.c            |   3 +-
 tests/i915/i915_pciid.c                 |   2 +
 tests/i915/i915_pm_dc.c                 |   1 +
 tests/i915/kms_big_fb.c                 |   1 +
 tests/i915/kms_big_joiner.c             |   1 +
 tests/i915/kms_busy.c                   |   1 +
 tests/i915/kms_ccs.c                    |   4 +-
 tests/i915/kms_cdclk.c                  |   1 +
 tests/i915/kms_fence_pin_leak.c         |   1 +
 tests/i915/kms_flip_scaled_crc.c        |   1 +
 tests/i915/kms_flip_tiling.c            |   1 +
 tests/i915/kms_mmap_write_crc.c         |   1 +
 tests/i915/kms_pipe_b_c_ivb.c           |   1 +
 tests/i915/kms_psr.c                    |   1 +
 tests/i915/kms_psr2_sf.c                |   1 +
 tests/i915/kms_psr2_su.c                |   1 +
 tests/i915/kms_pwrite_crc.c             |   1 +
 tests/kms_3d.c                          |   1 +
 tests/kms_atomic.c                      |   1 +
 tests/kms_atomic_interruptible.c        |   1 +
 tests/kms_atomic_transition.c           |   1 +
 tests/kms_color.c                       |   1 +
 tests/kms_content_protection.c          |   1 +
 tests/kms_cursor_crc.c                  |   1 +
 tests/kms_cursor_edge_walk.c            |   4 +-
 tests/kms_cursor_legacy.c               |   1 +
 tests/kms_dither.c                      |   1 +
 tests/kms_dp_aux_dev.c                  |   1 +
 tests/kms_flip.c                        |   3 +
 tests/kms_flip_event_leak.c             |   1 +
 tests/kms_force_connector_basic.c       |   7 +-
 tests/kms_hdmi_inject.c                 |   1 +
 tests/kms_hdr.c                         |   1 +
 tests/kms_invalid_mode.c                |   1 +
 tests/kms_panel_fitting.c               |   4 +-
 tests/kms_pipe_crc_basic.c              |   1 +
 tests/kms_plane.c                       |   1 +
 tests/kms_plane_alpha_blend.c           |   1 +
 tests/kms_plane_cursor.c                |   1 +
 tests/kms_plane_lowres.c                |   4 +-
 tests/kms_plane_multiple.c              |   4 +-
 tests/kms_plane_scaling.c               |   4 +-
 tests/kms_properties.c                  |   1 +
 tests/kms_rotation_crc.c                |   1 +
 tests/kms_scaling_modes.c               |   4 +-
 tests/kms_sequence.c                    |   4 +
 tests/kms_universal_plane.c             |   1 +
 tests/kms_vblank.c                      |   4 +
 tests/syncobj_basic.c                   |   4 +
 tests/syncobj_timeline.c                |   4 +
 tests/syncobj_wait.c                    |   4 +
 83 files changed, 385 insertions(+), 33 deletions(-)
 create mode 100644 lib/igt_types.c
 create mode 100644 lib/igt_types.h
 create mode 100644 lib/tests/bad_subtest_type.c
 create mode 100644 lib/tests/igt_types.c
Signature · 1 line
2.37.3