Skip to content

refactor push pending

Geliang Tang mptcp 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest4 patches 5 repliesIn review
  2. v815 patches 6 repliesSuperseded
  3. v712 patches 2 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v613 patches5 repliesSuperseded
v511 patches7 repliesSuperseded
v411 patches6 repliesSuperseded
v35 patches2 repliesSuperseded
v24 patches3 repliesSuperseded
v14 patches4 repliesSuperseded

Changes in v9 from the cover letter

- move "register default scheduler" out of this series.
- add missing "first = false" in patch 4
- patch 2 could be merged before the commit "mptcp: add struct mptcp_sched_ops" as a non-bpf cleanup.

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Squash to "mptcp: add get_subflow wrappers"net/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/sched.c+35 -380 replies
2/4mptcp: use msk instead of mptcp_sknet/mptcp/protocol.c+5 -50 replies
3/4mptcp: change 'first' as a parameternet/mptcp/protocol.c+6 -140 replies
4/4mptcp: refactor push_pending logicnet/mptcp/protocol.c+70 -853 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMat Martineau
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH mptcp-next v9 0/4] refactor push pending

v9:
- move "register default scheduler" out of this series.
- add missing "first = false" in patch 4
- patch 2 could be merged before the commit "mptcp: add struct mptcp_sched_ops" as a non-bpf cleanup.

v8:
- merge "register default scheduler" into this series.
- Move "multi-subflow scheduling" out of this series.
- This series should be merged between the commit "mptcp: add get_subflow wrappers" and "bpf: Add bpf_mptcp_sched_ops", except the squash-to patches.

v7:
- update delegate sending in patch 10
- rebase to export/20221011T063543.

v6:
- drop all msk->last_snd, add last_snd variable instead in patch 13
- fix lock_sock issue in patch 3
- merge squash-to patches

v5:
- address Mat's comments in v4.

v4:
- update __mptcp_subflow_push_pending as Mat suggested.
- add more patches from "BPF redundant scheduler" series.

v3:
- add a cleanup patch.
- remove msk->last_snd in mptcp_subflow_get_send().
- add the loop that calls the scheduler again in __mptcp_push_pending().

v2:
- add snd_burst check in dfrags loop as Mat suggested.

Refactor __mptcp_push_pending() and __mptcp_subflow_push_pending() to remove duplicate code and support redundant scheduler more easily in __mptcp_subflow_push_pending().

Geliang Tang (4):
Squash to "mptcp: add get_subflow wrappers"
mptcp: use msk instead of mptcp_sk
mptcp: change 'first' as a parameter
mptcp: refactor push_pending logic

 net/mptcp/protocol.c | 183 +++++++++++++++++++------------------------
 net/mptcp/protocol.h |   4 +-
 net/mptcp/sched.c    |  61 +++++++--------
 3 files changed, 111 insertions(+), 137 deletions(-)
Signature · 1 line
2.35.3