Skip to content

macsec: replace custom netlink attribute checks with policy-level checks

Sabrina Dubroca llvm netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12macsec: replace custom checks on MACSEC_SA_ATTR_AN with NLA_POLICY_MAXdrivers/net/macsec.c+1 -140 replies
2/12macsec: replace custom checks on MACSEC_*_ATTR_ACTIVE with NLA_POLICY_MAXdrivers/net/macsec.c+2 -230 replies
3/12macsec: replace custom checks on MACSEC_SA_ATTR_SALT with NLA_POLICY_EXACT_LENdrivers/net/macsec.c+1 -180 replies
4/12macsec: replace custom checks on MACSEC_SA_ATTR_KEYID with NLA_POLICY_EXACT_LENdrivers/net/macsec.c+1 -80 replies
5/12macsec: use NLA_POLICY_VALIDATE_FN to validate MACSEC_SA_ATTR_PNdrivers/net/macsec.c+14 -110 replies
6/12macsec: add NLA_POLICY_MAX for MACSEC_OFFLOAD_ATTR_TYPE and IFLA_MACSEC_OFFLOADdrivers/net/macsec.c+2 -10 replies
7/12macsec: replace custom checks on IFLA_MACSEC_ICV_LEN with NLA_POLICY_RANGEdrivers/net/macsec.c+1 -40 replies
8/12macsec: use NLA_POLICY_VALIDATE_FN to validate IFLA_MACSEC_CIPHER_SUITEdrivers/net/macsec.c+18 -121 reply
9/12macsec: validate IFLA_MACSEC_VALIDATION with NLA_POLICY_MAXdrivers/net/macsec.c+1 -50 replies
10/12macsec: replace custom checks for IFLA_MACSEC_* flags with NLA_POLICY_MAXdrivers/net/macsec.c+6 -160 replies
11/12macsec: replace custom check on IFLA_MACSEC_ENCODING_SA with NLA_POLICY_MAXdrivers/net/macsec.c+1 -60 replies
12/12macsec: remove validate_add_rxscdrivers/net/macsec.c+2 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 00/12] macsec: replace custom netlink attribute checks with policy-level checks

We can simplify attribute validation a lot by describing the accepted ranges more precisely in the policies, using NLA_POLICY_MAX etc.

Some of the checks still need to be done later on, because the attribute length and acceptable range can vary based on values that can't be known when the policy is validated (cipher suite determines the key length and valid ICV length, presence of XPN changes the PN length, detection of duplicate SCIs or ANs, etc).

As a bonus, we get a few extack messages from the policy validation. I'll add extack to the rest of the checks (mostly in the genl commands) in an future series.

Sabrina Dubroca (12):
macsec: replace custom checks on MACSEC_SA_ATTR_AN with NLA_POLICY_MAX
macsec: replace custom checks on MACSEC_*_ATTR_ACTIVE with
NLA_POLICY_MAX
macsec: replace custom checks on MACSEC_SA_ATTR_SALT with
NLA_POLICY_EXACT_LEN
macsec: replace custom checks on MACSEC_SA_ATTR_KEYID with
NLA_POLICY_EXACT_LEN
macsec: use NLA_POLICY_VALIDATE_FN to validate MACSEC_SA_ATTR_PN
macsec: add NLA_POLICY_MAX for MACSEC_OFFLOAD_ATTR_TYPE and
IFLA_MACSEC_OFFLOAD
macsec: replace custom checks on IFLA_MACSEC_ICV_LEN with
NLA_POLICY_RANGE
macsec: use NLA_POLICY_VALIDATE_FN to validate
IFLA_MACSEC_CIPHER_SUITE
macsec: validate IFLA_MACSEC_VALIDATION with NLA_POLICY_MAX
macsec: replace custom checks for IFLA_MACSEC_* flags with
NLA_POLICY_MAX
macsec: replace custom check on IFLA_MACSEC_ENCODING_SA with
NLA_POLICY_MAX
macsec: remove validate_add_rxsc

 drivers/net/macsec.c | 178 ++++++++++++-------------------------------
 1 file changed, 50 insertions(+), 128 deletions(-)
Signature · 1 line
2.37.3