Skip to content

Qemu SEV reduced-phys-bits fixes

Tom Lendacky kvm qemu-devel 1 version Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4qapi, i386/sev: Change the reduced-phys-bits value from 5 to 1qapi/misc-target.json+1 -11 reply
2/4qemu-options.hx: Update the reduced-phys-bits documentationqemu-options.hx+2 -21 reply
3/4i386/sev: Update checks and information related to reduced-phys-bitstarget/i386/sev.c+14 -31 reply
4/4i386/cpu: Update how the EBX register of CPUID 0x8000001F is settarget/i386/cpu.c+2 -21 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDr. David Alan Gilbert
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Qemu SEV reduced-phys-bits fixes

This patch series fixes up and tries to remove some confusion around the SEV reduced-phys-bits parameter.

Based on the "AMD64 Architecture Programmer's Manual Volume 2: System Programming", section "15.34.6 Page Table Support" [1], a guest should only ever see a maximum of 1 bit of physical address space reduction.

- Update the documentation, to change the default value from 5 to 1.
- Update the validation of the parameter to ensure the parameter value is within the range of the CPUID field that it is reported in. To allow for backwards compatibility, especially to support the previously documented value of 5, allow the full range of values from 1 to 63 (0 was never allowed).
- Update the setting of CPUID 0x8000001F_EBX to limit the values to the field width that they are setting as an additional safeguard.

[1] https://www.amd.com/system/files/TechDocs/24593.pdf

Tom Lendacky (4):
qapi, i386/sev: Change the reduced-phys-bits value from 5 to 1 qemu-options.hx: Update the reduced-phys-bits documentation i386/sev: Update checks and information related to reduced-phys-bits i386/cpu: Update how the EBX register of CPUID 0x8000001F is set

 qapi/misc-target.json |  2 +-
 qemu-options.hx       |  4 ++--
 target/i386/cpu.c     |  4 ++--
 target/i386/sev.c     | 17 ++++++++++++++---
 4 files changed, 19 insertions(+), 8 deletions(-)
Signature · 1 line
2.37.3