Skip to content

RFC drm/connector: connector iterator with filtering

Jani Nikula dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/connector: add connector list iteration with filteringdrivers/gpu/drm/drm_connector.c include/drm/drm_connector.h+54 -123 replies
2/2drm/i915: iterate intel_connectors onlydrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp.c +5 more+35 -140 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHarry WentlandLaurent Pinchart
SeriesA-b
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/2] drm/connector: connector iterator with filtering

Currently i915 assumes all drm_connectors it encounters are embedded in intel_connectors that i915 allocated. The drm_writeback_connector forces a design where this is not the case; we can't provide our own connector, and writeback embeds the drm_connector it initializes itself.

To use drm writeback, none of the i915 connector iteration could assume the drm connector is embedded in intel_connector. Checking this is tedious, and would require an intermediate step with drm_connector. Here's an idea I came up with; filtering at the drm connector iterator level with a caller supplied function. Not too much code, and could be used for other things as well.

Mind you, we'd still much rather modify drm writeback to allow passing the connector i915 allocated, instead of the current midlayer design that forces drivers to a certain model. Working around this is a bunch of error prone and tedious code that we really could do without.

BR,
Jani.

Cc Arun R Murthy <[email protected]>
Cc Dave Airlie <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Suraj Kandpal <[email protected]>
Cc Ville Syrjälä <[email protected]>

Jani Nikula (2):
drm/connector: add connector list iteration with filtering drm/i915: iterate intel_connectors only

 drivers/gpu/drm/drm_connector.c               | 57 +++++++++++++++----
 drivers/gpu/drm/i915/display/intel_display.c  |  3 +-
 .../drm/i915/display/intel_display_types.h    |  7 +++
 drivers/gpu/drm/i915/display/intel_dp.c       |  6 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |  3 +-
 drivers/gpu/drm/i915/display/intel_hdcp.c     |  3 +-
 drivers/gpu/drm/i915/display/intel_hotplug.c  | 12 ++--
 .../drm/i915/display/intel_modeset_setup.c    |  6 +-
 drivers/gpu/drm/i915/display/intel_opregion.c |  9 ++-
 include/drm/drm_connector.h                   |  9 +++
 10 files changed, 89 insertions(+), 26 deletions(-)
Signature · 1 line
2.34.1