Skip to content

RFC netlink: formatted extacks

[email protected] netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3netlink: add support for formatted extack messagesinclude/linux/netlink.h+19 -210 replies
2/3sfc: use formatted extacks instead of efx_tc_err()drivers/net/ethernet/sfc/mae.c drivers/net/ethernet/sfc/tc.c drivers/net/ethernet/sfc/tc.h+23 -470 replies
3/3sfc: remove 'log-tc-errors' ethtool private flagdrivers/net/ethernet/sfc/ef100_ethtool.c drivers/net/ethernet/sfc/ethtool_common.c drivers/net/ethernet/sfc/ethtool_common.h +1 more+0 -430 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH net-next 0/3] netlink: formatted extacks

From: Edward Cree <[email protected]>

Currently, netlink extacks can only carry fixed string messages, which
is limiting when reporting failures in complex systems. This series adds the ability to return printf-formatted messages, and uses it in the sfc driver's TC offload code.
Formatted extack messages are limited in length to a fixed buffer size,
currently 80 characters.
There is no change to the netlink uAPI; only internal kernel changes
are needed.

Edward Cree (3):
netlink: add support for formatted extack messages
sfc: use formatted extacks instead of efx_tc_err()
sfc: remove 'log-tc-errors' ethtool private flag

 drivers/net/ethernet/sfc/ef100_ethtool.c  |  2 -
 drivers/net/ethernet/sfc/ethtool_common.c | 37 ------------------
 drivers/net/ethernet/sfc/ethtool_common.h |  2 -
 drivers/net/ethernet/sfc/mae.c            |  5 +--
 drivers/net/ethernet/sfc/net_driver.h     |  2 -
 drivers/net/ethernet/sfc/tc.c             | 47 ++++++++++-------------
 drivers/net/ethernet/sfc/tc.h             | 18 ---------
 include/linux/netlink.h                   | 21 +++++++++-
 8 files changed, 42 insertions(+), 92 deletions(-)