Skip to content

macsec: offload-related fixes

Sabrina Dubroca netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesApplied 5/5
  2. v25 patches 9 repliesSuperseded
  3. v15 patches 15 repliesSuperseded

Changes in v3 from the cover letter

- patch #3: drop extra newline (Jakub Kicinski)

Patches in v3 All 5 applied

#Subject and filesSizeRepliesApplied
1/5Revert "net: macsec: report real_dev features when HW offloading is enabled"drivers/net/macsec.c+4 -230 repliesApplied
2/5macsec: delete new rxsc when offload failsdrivers/net/macsec.c+2 -30 repliesApplied
3/5macsec: fix secy->n_rx_sc accountingdrivers/net/macsec.c+8 -60 repliesApplied
4/5macsec: fix detection of RXSCs when toggling offloadingdrivers/net/macsec.c+1 -10 repliesApplied
5/5macsec: clear encryption keys from the stack after setting up offloaddrivers/net/macsec.c+2 -00 repliesApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAntoine TenartLeon Romanovsky
1/5R-b R-b
2/5R-b R-b
3/5R-b R-b
4/5R-b R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net v3 0/5] macsec: offload-related fixes

I'm working on a dummy offload for macsec on netdevsim. It just has a small SecY and RXSC table so I can trigger failures easily on the ndo_* side. It has exposed a couple of issues.

The first patch is a revert of commit c850240b6c41 ("net: macsec:
report real_dev features when HW offloading is enabled"). That commit tried to improve the performance of macsec offload by taking advantage of some of the NIC's features, but in doing so, broke macsec offload when the lower device supports both macsec and ipsec offload, as the ipsec offload feature flags were copied from the real device. Since the macsec device doesn't provide xdo_* ops, the XFRM core rejects the registration of the new macsec device in xfrm_api_check.

I'm working on re-adding those feature flags when offload is available, but I haven't fully solved that yet. I think it would be safer to do that second part in net-next considering how complex feature interactions tend to be.

v2:
- better describe the issue introduced by commit c850240b6c41 (Leon Romanovsky)
- patch #3: drop unnecessary !! (Leon Romanovsky)

v3:
- patch #3: drop extra newline (Jakub Kicinski)

Sabrina Dubroca (5):
Revert "net: macsec: report real_dev features when HW offloading is
enabled"
macsec: delete new rxsc when offload fails
macsec: fix secy->n_rx_sc accounting
macsec: fix detection of RXSCs when toggling offloading
macsec: clear encryption keys from the stack after setting up offload

 drivers/net/macsec.c | 50 +++++++++++++++-----------------------------
 1 file changed, 17 insertions(+), 33 deletions(-)
Signature · 1 line
2.38.0