Skip to content

drm/edid: EDID override refactoring and fixes

Jani Nikula amd-gfx dri-devel intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest16 patches 6 repliesIn review
  2. v115 patches 23 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16drm/i915/hdmi: do dual mode detect only if connecteddrivers/gpu/drm/i915/display/intel_hdmi.c+7 -100 replies
2/16drm/i915/hdmi: stop using connector->override_ediddrivers/gpu/drm/i915/display/intel_hdmi.c+1 -41 reply
3/16drm/amd/display: stop using connector->override_ediddrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+0 -30 replies
4/16drm/edid: debug log EDID override set/resetdrivers/gpu/drm/drm_edid.c+6 -00 replies
5/16drm/edid: abstract debugfs override EDID show betterdrivers/gpu/drm/drm_crtc_internal.h drivers/gpu/drm/drm_debugfs.c drivers/gpu/drm/drm_edid.c+15 -80 replies
6/16drm/edid: rename drm_add_override_edid_modes() to drm_edid_override_connector_update()drivers/gpu/drm/drm_edid.c drivers/gpu/drm/drm_probe_helper.c include/drm/drm_edid.h+5 -50 replies
7/16drm/edid: split drm_edid block count helperdrivers/gpu/drm/drm_edid.c+11 -40 replies
8/16drm/edid: add function for checking drm_edid validitydrivers/gpu/drm/drm_edid.c include/drm/drm_edid.h+31 -00 replies
9/16drm/edid: detach debugfs EDID override from EDID property updatedrivers/gpu/drm/drm_connector.c drivers/gpu/drm/drm_edid.c include/drm/drm_connector.h+49 -411 reply
10/16drm/edid/firmware: drop redundant connector_name variable/parameterdrivers/gpu/drm/drm_edid_load.c+7 -90 replies
11/16drm/edid/firmware: rename drm_load_edid_firmware() to drm_edid_load_firmware()drivers/gpu/drm/drm_edid.c drivers/gpu/drm/drm_edid_load.c include/drm/drm_edid.h+8 -80 replies
12/16drm/edid: use struct drm_edid for override/firmware EDIDdrivers/gpu/drm/drm_edid.c drivers/gpu/drm/drm_edid_load.c include/drm/drm_edid.h+36 -860 replies
13/16drm/edid: move edid load declarations to internal headerdrivers/gpu/drm/drm_crtc_internal.h drivers/gpu/drm/drm_edid_load.c include/drm/drm_edid.h+14 -90 replies
14/16drm/edid/firmware: convert to drm device specific loggingdrivers/gpu/drm/drm_edid_load.c+8 -41 reply
15/16drm/edid: add [CONNECTOR:%d:%s] to debug loggingdrivers/gpu/drm/drm_edid.c+25 -131 reply
16/16drm/edid: convert to device specific loggingdrivers/gpu/drm/drm_edid.c+77 -601 reply

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchVille SyrjäläHarry WentlandAlex DeucherSimon Ser
1/16R-b
2/16R-b
3/16R-b A-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16R-b
10/16R-b
11/16R-b
12/16R-b
13/16R-b
14/16R-b
15/16R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/16] drm/edid: EDID override refactoring and fixes

v2 of drm/edid: EDID override refactoring and fixes

Address review comments, add patch 15.

BR,
Jani.

Jani Nikula (16):
drm/i915/hdmi: do dual mode detect only if connected drm/i915/hdmi: stop using connector->override_edid drm/amd/display: stop using connector->override_edid drm/edid: debug log EDID override set/reset
drm/edid: abstract debugfs override EDID show better drm/edid: rename drm_add_override_edid_modes() to
drm_edid_override_connector_update()
drm/edid: split drm_edid block count helper
drm/edid: add function for checking drm_edid validity drm/edid: detach debugfs EDID override from EDID property update drm/edid/firmware: drop redundant connector_name variable/parameter drm/edid/firmware: rename drm_load_edid_firmware() to
drm_edid_load_firmware()
drm/edid: use struct drm_edid for override/firmware EDID drm/edid: move edid load declarations to internal header drm/edid/firmware: convert to drm device specific logging drm/edid: add [CONNECTOR:%d:%s] to debug logging drm/edid: convert to device specific logging

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   3 -
 drivers/gpu/drm/drm_connector.c               |   1 +
 drivers/gpu/drm/drm_crtc_internal.h           |  15 +-
 drivers/gpu/drm/drm_debugfs.c                 |   8 +-
 drivers/gpu/drm/drm_edid.c                    | 346 +++++++++++-------
 drivers/gpu/drm/drm_edid_load.c               | 109 ++----
 drivers/gpu/drm/drm_probe_helper.c            |   2 +-
 drivers/gpu/drm/i915/display/intel_hdmi.c     |  20 +-
 include/drm/drm_connector.h                   |  16 +-
 include/drm/drm_edid.h                        |  10 +-
 10 files changed, 283 insertions(+), 247 deletions(-)
Signature · 1 line
2.34.1