staging: r8188eu: trivial code cleanup patches
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest11 patches 10 repliesIn review
- v310 patches 12 repliesSuperseded
- v14 patches 2 repliesSuperseded
Changes in v4 from the cover letter
1. Include patch 11 in the set for unused macro clean up. Suggested by [email protected]
2. Update patch 1 per feedback from [email protected]
3. Update patch 5 & 6 per feedback from [email protected] & [email protected]
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | staging: r8188eu: use Linux kernel variable naming conventiondrivers/ | +56 | 0 replies | |
| 2/11 | staging: r8188eu: reformat long computation linesdrivers/ | +6 | 0 replies | |
| 3/11 | staging: r8188eu: remove {} for single statement blocksdrivers/ | +1 | 0 replies | |
| 4/11 | staging: r8188eu: use htons macro instead of __constant_htonsdrivers/ drivers/ | +10 | 0 replies | |
| 5/11 | staging: r8188eu: correct misspelled words in commentsdrivers/ drivers/ drivers/ +12 more | +54 | 0 replies | |
| 6/11 | staging: r8188eu: Add space between function & macro parametersdrivers/ drivers/ drivers/ +1 more | +26 | 0 replies | |
| 7/11 | staging: r8188eu: Associate pointer symbol with parameter namedrivers/ drivers/ drivers/ +2 more | +16 | 0 replies | |
| 8/11 | staging: r8188eu: replace leading spaces by tabsdrivers/ drivers/ drivers/ | +7 | 2 replies | |
| 9/11 | staging: r8188eu: Put '{" on the symbol declaration linedrivers/ | +6 | 0 replies | |
| 10/11 | staging: r8188eu: Correct missing or extra space in the statementsdrivers/ drivers/ drivers/ | +16 | 0 replies | |
| 11/11 | staging: r8188eu: Remove unused macrosdrivers/ | +0 | 5 replies |
Reviews trailers per patch
None of the 11 patches has a Reviewed-by or Acked-by.
| Patch | Philipp Hortmann |
|---|---|
| Series | T-b |
| 1/11 | |
| 2/11 | |
| 3/11 | |
| 4/11 | |
| 5/11 | |
| 6/11 | |
| 7/11 | |
| 8/11 | |
| 9/11 | |
| 10/11 | |
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/11] staging: r8188eu: trivial code cleanup patches
Address different kinds of checkpatch complains for the staging/r8188eu module. The patches are required to be applied in sequence.
Changes in v4:
1. Include patch 11 in the set for unused macro clean up. Suggested by [email protected]
2. Update patch 1 per feedback from [email protected]
3. Update patch 5 & 6 per feedback from [email protected] & [email protected]
Changes in v3:
1. Patch 4: Extend the __constant_htons to htons change to other files of the driver. This was suggested by [email protected]
2. Patch 4: Spelling mistake corrected as pointed out by [email protected]
3. Patch 5 through 10: Included in this version. Additional clean up patches.
Changes in v2:
I incorrectly labeled the first revision as v1 instead of v2. So, following change recorded under v1 is actually changes for v2. Feedback provided by [email protected]
1. Improve language / grammar for the patch descriptions
2. Further improve code reformatting
Deepak R Varma (11):
staging: r8188eu: use Linux kernel variable naming convention
staging: r8188eu: reformat long computation lines
staging: r8188eu: remove {} for single statement blocks
staging: r8188eu: use htons macro instead of __constant_htons
staging: r8188eu: correct misspelled words in comments
staging: r8188eu: Add space between function & macro parameters
staging: r8188eu: Associate pointer symbol with parameter name
staging: r8188eu: replace leading spaces by tabs
staging: r8188eu: Put '{" on the symbol declaration line
staging: r8188eu: Correct missing or extra space in the statements
staging: r8188eu: Remove unused macros
drivers/staging/r8188eu/core/rtw_br_ext.c | 119 +++++++++--------- drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 36 +++--- drivers/staging/r8188eu/core/rtw_recv.c | 8 +- drivers/staging/r8188eu/core/rtw_xmit.c | 14 +-- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 2 +- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 2 +- .../staging/r8188eu/hal/rtl8188e_hal_init.c | 2 +- drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 16 +-- .../staging/r8188eu/include/Hal8188EPhyReg.h | 4 +- .../staging/r8188eu/include/osdep_service.h | 4 +- .../staging/r8188eu/include/rtl8188e_hal.h | 6 +- .../staging/r8188eu/include/rtl8188e_spec.h | 18 +-- drivers/staging/r8188eu/include/rtw_cmd.h | 62 +++++---- drivers/staging/r8188eu/include/rtw_io.h | 16 +-- .../staging/r8188eu/include/rtw_ioctl_set.h | 4 +- drivers/staging/r8188eu/include/rtw_mlme.h | 22 ++-- .../staging/r8188eu/include/rtw_mlme_ext.h | 12 +- drivers/staging/r8188eu/include/rtw_recv.h | 4 +- drivers/staging/r8188eu/include/rtw_xmit.h | 2 +- drivers/staging/r8188eu/include/wifi.h | 12 +- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 6 +- 22 files changed, 176 insertions(+), 197 deletions(-)
--
2.30.2