Skip to content

staging: rtl8712: clean up dynamic memory management

Nam Cao linux-staging lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyIn review
  2. v14 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Revert "staging: r8712u: Tracking kmemleak false positives."drivers/staging/rtl8712/rtl871x_recv.c+0 -30 replies
2/4staging: rtl8712: check for alloc fail in _r8712_init_recv_priv()drivers/staging/rtl8712/os_intfs.c drivers/staging/rtl8712/recv_osdep.h drivers/staging/rtl8712/rtl8712_recv.c +1 more+20 -120 replies
3/4staging: rtl8712: check for return value of _r8712_init_xmit_priv()drivers/staging/rtl8712/os_intfs.c+3 -10 replies
4/4staging: rtl8712: fix potential memory leakdrivers/staging/rtl8712/os_intfs.c+18 -50 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchPhilipp Hortmann
SeriesT-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] staging: rtl8712: clean up dynamic memory management

This driver is fine if memory allocation never fails. However it does not handle allocation failure well. This can either lead to memory leak, or unallocated buffers being used.

v2: Add a missing if statement, as noticed by Dan Carpenter

Nam Cao (4):
Revert "staging: r8712u: Tracking kmemleak false positives."
staging: rtl8712: check for alloc fail in _r8712_init_recv_priv()
staging: rtl8712: check for return value of _r8712_init_xmit_priv()
staging: rtl8712: fix potential memory leak

 drivers/staging/rtl8712/os_intfs.c     | 27 +++++++++++++++++++++-----
 drivers/staging/rtl8712/recv_osdep.h   |  8 ++++----
 drivers/staging/rtl8712/rtl8712_recv.c |  7 ++++---
 drivers/staging/rtl8712/rtl871x_recv.c | 16 ++++++++-------
 4 files changed, 39 insertions(+), 19 deletions(-)
Signature · 1 line
2.25.1